process-mail.py "need more than 1 value to unpack"

Bug #504124 reported by Stuart Bishop on 2010-01-07
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Diogo Matsubara

Bug Description

Every hour, process-mail.py is generating several error messages of the form:

2010-01-07 02:33:15 ERROR An exception was raised inside the handler:
[...] (need more than 1 value to unpack)

The traceback is:

Traceback (most recent call last):
  File "/srv/launchpad.net/production/launchpad-rev-8806/lib/canonical/launchpad/mail/incoming.py", line 275, in handleMail
    user, domain = email_addr.split('@')
ValueError: need more than 1 value to unpack

The trigger is a malformed To: header - an attempt by spammers to get things past filters:

To: <<email address hidden>,
 <email address hidden>,
 <email address hidden>,
 <email address hidden>,
 <email address hidden>>

We need to handle this better to allow us to again monitor this script for genuine failures.

Recently: OOPS-1607CEMAIL801

Related branches

Curtis Hovey (sinzui) wrote :

Will a simple try/except suffice with a comment that we break because the email/domain is not valid?

affects: launchpad → launchpad-foundations
Changed in launchpad-foundations:
importance: Undecided → High
status: New → Triaged
tags: added: oops
description: updated
Gary Poster (gary) on 2010-05-27
Changed in launchpad-foundations:
assignee: nobody → Diogo Matsubara (matsubara)
milestone: none → 10.05
Tom Haddon (mthaddon) on 2010-05-28
tags: added: canonical-losa-lp
Changed in launchpad-foundations:
status: Triaged → Fix Committed
Curtis Hovey (sinzui) on 2010-06-02
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
tags: added: qa-ok
removed: qa-needstesting
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers