Please put the URL to the merge proposal in the body of the email

Bug #504080 reported by James Westby on 2010-01-07
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Aaron Bentley

Bug Description


Some people will get a merge proposal email without being
intimately familiar with the system. Currently the email isn't very instructive
about how to deal with it, it's just descriptive of the situation.

Putting instructions in the email may not be wise, and we have a web UI
that is designed to lead people through the process, so we should send
inexperienced people there, and let the experienced users do as they like.

Currently the only link in the mail is in the signature, which some mail clients
hide, and isn't front and center so may be missed.

I would suggest putting the link somewhere near the top of the mail, probably
under the requested reviews:

  Subject: [Merge] lp:~geser/ubuntu/lucid/gnupg/gnupg-merge-1.4.10-2 into lp:ubuntu/gnupg
  Michael Bienia has proposed merging lp:~geser/ubuntu/lucid/gnupg/gnupg-merge-1.4.10-2 into lp:ubuntu/gnupg.

      Requested reviews:
      Ubuntu Sponsors for main (ubuntu-main-sponsors)

  See more details and review the request at

  gnupg (1.4.10-2ubuntu1) lucid; urgency=low

    * Merge from Debian testing. Remaining changes:
      - Add 'debian/patches/50_disable_mlock_test.dpatch': Disable mlock() test
        since it fails with ulimit 0 (on buildds).
      - Add 'debian/patches/61_use_agent_default.dpatch': Patch to set gpg
        (or gpg2) and gpgsm to use a passphrase agent by default (lp: 15485)
      - Fix udeb build failure on powerpc, building with -O2 instead of -Os.

   -- Michael Bienia <email address hidden> Wed, 30 Dec 2009 23:23:09 +0100The attached diff has been truncated due to its size.
[2-line signature. Click/Enter to show.]




Related branches

Tim Penhey (thumper) wrote :

Nice suggestion and example.

Changed in launchpad-code:
importance: Undecided → Medium
status: New → Triaged
tags: added: code-review email trivial

On Thu, 07 Jan 2010 01:59:39 -0000, Tim Penhey <email address hidden> wrote:
> Nice suggestion and example.

I had a look for the code for this, and I saw where the existing details
were put in a dict, but it was too twisty for me to find the template
from that. Details may encourage to find a spare few minutes for this.



2010/1/7 James Westby <email address hidden>:
> Currently the only link in the mail is in the signature, which some mail clients
> hide, and isn't front and center so may be missed.

Different mails sent by Launchpad are inconsistent about this. Maybe
it could go into the developer docs.

Martin <>

Aaron Bentley (abentley) on 2010-12-20
tags: added: bugjam2010
Changed in launchpad:
assignee: nobody → Aaron Bentley (abentley)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Aaron Bentley (abentley) on 2010-12-22
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui) on 2010-12-23
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui) on 2011-01-11
Changed in launchpad:
milestone: none → 11.01
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers