Custom upload file privacy not updated
Bug #503258 reported by
William Grant
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Steve Kowalik | ||
Bug Description
Custom upload files are not moved to the public librarian during delayed copies. do_copy only returns [SB]PPHs, so any custom files (such as raw-translations tarballs) remain private and inaccessible.
Related branches
lp:~stevenk/launchpad/fixes-bug-503258
- Eleanor Berger (community): Approve (code)
-
Diff: 131 lines (+28/-8)5 files modifiedlib/lp/soyuz/configure.zcml (+2/-0)
lib/lp/soyuz/model/queue.py (+5/-0)
lib/lp/soyuz/scripts/packagecopier.py (+15/-6)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+2/-2)
lib/lp/soyuz/tests/test_packageupload.py (+4/-0)
| Changed in soyuz: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| milestone: | none → 10.02 |
Revision history for this message
| David Planella (dpm) wrote | #1 |
| Changed in soyuz: | |
| milestone: | 10.02 → 10.03 |
| Changed in soyuz: | |
| milestone: | 10.03 → pending |
| Changed in soyuz: | |
| assignee: | nobody → Steve Kowalik (stevenk) |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #2 |
| Changed in soyuz: | |
| milestone: | pending → 10.03 |
| status: | Triaged → Fix Committed |
| tags: | added: qa-needstesting |
Revision history for this message
| Ursula Junque (ursinha) wrote | #3 |
| tags: |
added: qa-ok removed: qa-needstesting |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Just a note on why the raw-translations tarballs are extremaly useful for the Ubuntu Translations Coordinators team:
When there are any issues in importing translations (.po files) or templates (.pot files) into Launchpad, we use a launchpadlib script to get the librarian locations and then download the raw-translations tarball to obtain and examine the exact file fed to Rosetta.
This saves us from locally building a local package from source and stripping out the translations also locally, which in some cases produces raw translations tarballs which do not quite match the raw-translations upload (e.g. in the case of KDE uploads).
This bug simply means that in the case of security uploads, we are not able to access those raw-translations tarballs