Launchpad itself

Test TranslationTemplatesBuildBehavior.dispatchBuildToSlave

Bug #500110 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Jeroen T. Vermeulen
Launchpad itself 10.01

Bug Description

TranslationTemplatesBuildBehavior.dispatchBuildToSlave still needs to be covered by tests, once the build farm gets to the point where this becomes usable.

Related branches

lp:~jtv/launchpad/bug-500110
Muharem Hrnjadovic (community): Approve (code)
Diff: 599 lines (+226/-90)
14 files modified
lib/lp/buildmaster/doc/buildfarmjob.txt (+20/-0)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+17/-0)
lib/lp/buildmaster/model/buildfarmjob.py (+18/-3)
lib/lp/code/model/branchjob.py (+2/-0)
lib/lp/soyuz/interfaces/buildqueue.py (+10/-3)
lib/lp/soyuz/model/buildpackagejob.py (+2/-1)
lib/lp/soyuz/model/buildqueue.py (+13/-11)
lib/lp/soyuz/tests/test_buildqueue.py (+26/-0)
lib/lp/translations/configure.zcml (+4/-2)
lib/lp/translations/doc/translationtemplatesbuildbehavior.txt (+82/-0)
lib/lp/translations/interfaces/translationtemplatesbuildjob.py (+3/-14)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+8/-36)
lib/lp/translations/model/translationtemplatesbuildjob.py (+9/-6)
lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+12/-14)
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

I think this can be tested now, even though it's only called from startBuild—which itself needs required_build_behavior to be generalized and so can't be tested on the new classes yet (it's currently still hard-coded).

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Muharem just landed the generalisation of BuildQueue.specific_job, and required_build_behavior is generalised as well. It should now be possible to test this.

Changed in rosetta:
status: New → In Progress
assignee: nobody → Jeroen T. Vermeulen (jtv)
importance: Undecided → Medium
Revision history for this message
Ursula Junque (ursinha) wrote : A commit mentioned this bug

This bug was mentioned in stable r10167 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10167>

Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Jeroen T. Vermeulen (jtv)
tags: added: qa-ok
removed: qa-needstesting
Ursula Junque (ursinha)
Changed in rosetta:
milestone: none → 10.01
Curtis Hovey (sinzui)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.