Re-activated users should also get their name restored.

[Henning Eggers]

Currently, if a user de-activates his/her account and later activates it again, the account name keeps the "-deactivatedaccount" suffix. This would look much better and be less confusing if the original name was restored upon re-activation, if possible.

[Curtis Hovey (sinzui)]

Person.reactivate() does fix the user name. I think the path for reactiving users has changed because user forgot password would ensure this was called LoginToken.reactivate().

[Selene ToyKeeper (toykeeper)]

I don't think this is working... I occasionally get delete-account requests from people with usernames like this:
https://launchpad.net/~cic-aster-deactivatedaccount-deactivatedaccount-deactivatedaccount-deactivatedaccount-deactivatedaccount-deactivatedaccount

[Curtis Hovey (sinzui)]

Login via SSO (which is the only way to login now) probably does not use reactivate().
/me looks
Oh, Nothing calls it now that SSO is used. So while Lp has a method to ensure reactivation is sane, nothing ever calls it.

[William Grant (wgrant)]

This relates to the reactivation and other account management workflows that I speculate on in https://bugs.launchpad.net/canonical-identity-provider/+bug/556680/comments/5

[William Grant (wgrant)]

            elif person.account.status in [AccountStatus.DEACTIVATED,
                                           AccountStatus.NOACCOUNT]:
                removeSecurityProxy(person.account).reactivate(comment)
                removeSecurityProxy(person).setPreferredEmail(email)

It seems like those two rSP lines could just be replaced with removeSecurityProxy(person).reactivate(comment, email).