Build state transitions are a messy nightmare
Bug #497944 reported by
Julian Edwards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
William Grant | ||
Bug Description
Build states (Build.buildstate) transitions are managed all over the code in different places and is a mess of disgusting code that can leave the buildd-manager stuck in some situations if the data is inconsistent across Job, BuildpackageJob and Buildqueue.
We should refactor the state transitions into a single class that deals with the behaviour of a build and has more checks that the data cannot get into a bad state.
| tags: | added: buildd-manager |
| Changed in soyuz: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #1 |
| Changed in soyuz: | |
| importance: | High → Low |
| Changed in soyuz: | |
| assignee: | Jelmer Vernooij (jelmer) → nobody |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → Fix Released |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #2 |
To post a comment you must log in.
Example, today we managed to get a Job that had a date_started but the buildqueue had a null builder. It should be impossible to get into this situation but if we do, buildd-manager should reset the build and carry on.