Build state transitions are a messy nightmare

Reported by Julian Edwards on 2009-12-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
William Grant

Bug Description

Build states (Build.buildstate) transitions are managed all over the code in different places and is a mess of disgusting code that can leave the buildd-manager stuck in some situations if the data is inconsistent across Job, BuildpackageJob and Buildqueue.

We should refactor the state transitions into a single class that deals with the behaviour of a build and has more checks that the data cannot get into a bad state.

tags: added: buildd-manager
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Jelmer Vernooij (jelmer)
Julian Edwards (julian-edwards) wrote :

Example, today we managed to get a Job that had a date_started but the buildqueue had a null builder. It should be impossible to get into this situation but if we do, buildd-manager should reset the build and carry on.

Changed in soyuz:
importance: High → Low
Jelmer Vernooij (jelmer) on 2010-12-14
Changed in soyuz:
assignee: Jelmer Vernooij (jelmer) → nobody
William Grant (wgrant) on 2013-08-12
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → Fix Released
Julian Edwards (julian-edwards) wrote :

\o/

What no attached branch?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers