next sprite icons shown in vocab picker

[Martin Pool]

In the product vocabulary picker, the icons look weirdly damaged (see attached) which makes it look like there is one more product below the last one visible on the page. Maybe a problem with using a sprite for this icon?

[Curtis Hovey (sinzui)]

The CSS rules for spacing do not agree with the sprite. The image and the first line of text are not aligned. I think the <li> and img rules in picker/assets/skins/sam/picker-sam.css need fixing.

ul.yui-picker-results li {
.yui-picker-results li img {
.yui-picker-results li

[Curtis Hovey (sinzui)]

Hi Beuno.

This bug relates to the sprite bugs you have been invesitgating. I think this is a little different because I think we are seeing a disagreement between launchpad css and lazr-js css. The fonts or spacing could be enforced in lazr-js, or we could review the CSS rules in launchpad and change them, adding a note why they it cannot be modified in the future.

I think I first saw this problem after Edwin landed a branch that adusted the spacing of <li>. I think there is too much space in the info portlets which I beleive share the spacing rules, so I suspect a small refinement had a very large impact.

[Martin Albisetti (beuno)]

Hi Sinzui,

I do think it can be tweaked and fixed easily. I do wonder however, if re-arranging sprites to be horizontal won't make all our problems go away...

Either way, I think that we may need to tweak Launchpad's CSS and add a comment blocking it from changing, so I agree!

[Edwin Grubbs (edwin-grubbs)]

In the UI meeting, I was tasked with fixing this by making it possible for the json to specify a css class for the title text instead of just being able to specify a css class for the entire <li>.

[Māris Fogels (mars)]

This is being fixed in Launchpad, as it is a site-specific problem with the sprite icons being used. It does not affect lazr-js.

See bug 405476 for the full conversation.