Unnecessary spaces and lines in new team member approval page

Bug #491320 reported by Emilien Klein
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Brad Crittenden

Bug Description

The page that is used to approve (or disapprove) new team members has a field that is used to add a comment.
This field contains by default spaces and lines. This field should be empty by default.

Url: https://launchpad.net/~<TEAM NAME>/+member/<USERNAME>

This also happens if you go to the page of a team member that has already been approved. In the attached screenshot you can see how "Welcome and thanks!" without any weird spaces or empty lines is rendered.

This is due to how you have coded the HTML for this page:

<pre>
 <textarea cols="40" name="comment">
   Welcome and thanks!
 </textarea>
</pre>

As you have a new line after the opening tag and spaces before the closing tag, those are displayed inside the textarea.

There should not be new lines between the opening and closing tags. They should be joined on the same line, with the (eventual) content in between.

Related branches

Revision history for this message
Emilien Klein (emilien-klein) wrote :
tags: added: ui
Curtis Hovey (sinzui)
affects: launchpad → launchpad-registry
Changed in launchpad-registry:
importance: Undecided → High
status: New → Triaged
tags: added: trivial
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 10.01
Brad Crittenden (bac)
Changed in launchpad-registry:
assignee: nobody → Brad Crittenden (bac)
Brad Crittenden (bac)
Changed in launchpad-registry:
status: Triaged → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.