+opstats should make no db requests
Bug #490221 reported by
Stuart Bishop
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Gary Poster | ||
Bug Description
A request to +opstats should make no database requests.
Turn on statement logging and check if it is accessing the db (eg. to check replication_lag() ).
Related branches
lp:~gary/launchpad/opstats-nodb
- Edwin Grubbs (community): Approve (code)
-
Diff: 16 lines (+4/-2)1 file modifiedlib/canonical/launchpad/webapp/dbpolicy.py (+4/-2)
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Gary Poster (gary) wrote | #1 |
| Changed in launchpad-foundations: | |
| assignee: | nobody → Gary Poster (gary) |
| status: | Triaged → In Progress |
| importance: | Medium → Critical |
| tags: | added: current-release-blocker |
Revision history for this message
| Gary Poster (gary) wrote | #2 |
| tags: |
added: current-rollout-blocker removed: current-release-blocker |
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #3 |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
| milestone: | none → 3.1.11 |
To post a comment you must log in.
Salgado found that it did make database requests in the ``install`` method of the database policy. He also found that suspicious looking related slowness in the postgres log. We are positing that this is the cause of the death spiral symptoms.