Launchpad itself

Accidentally unsubscribing myself from a private bug makes the bug inaccessible

Bug #485126 reported by Jonathan Lange
32
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Steve Kowalik

Bug Description

If I'm looking at a private bug that I'm subscribed to, I am allowed to unsubscribe myself. If I do so, I'm no longer allowed to view the bug, and I have no way of undoing the operation.

Since unsubscribing is a single click operation with no confirmation, this can lead to awkward accidents.

Related branches

lp:~stevenk/launchpad/private-bug-unsubscribe-confirm
Ian Booth (community): Approve (code)
Diff: 378 lines (+140/-81)
5 files modified
lib/lp/bugs/browser/bugsubscription.py (+6/-10)
lib/lp/bugs/javascript/bug_subscription_portlet.js (+2/-0)
lib/lp/bugs/javascript/subscription.js (+83/-59)
lib/lp/bugs/javascript/tests/test_subscription.html (+2/-0)
lib/lp/bugs/javascript/tests/test_subscription.js (+47/-12)
lp:~stevenk/launchpad/private-bug-unsubscribe-confirm-2
Ian Booth (community): Approve (code)
Diff: 233 lines (+129/-47)
3 files modified
lib/lp/bugs/browser/bug.py (+1/-0)
lib/lp/bugs/javascript/bug_subscription_portlet.js (+85/-47)
lib/lp/bugs/javascript/tests/test_bug_subscription_portlet.js (+43/-0)
Revision history for this message
Eleanor Berger (intellectronica) wrote :

Private bugs with no subscribers should be available to the bug supervisor for the project. At least until we have undo in LP.

Revision history for this message
Deryck Hodge (deryck) wrote :

I don't think we should add a confirmation step. As Tom says, undo (or something like undo) is the way to handle this. And that's something we need generally for many, if not all, of the AJAX actions we do.

Changed in malone:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Curtis Hovey (sinzui) wrote :

We intend to allow projects and distros to grant view permission to users and teams so that subscription is not necessary.

tags: added: disclosure
Revision history for this message
Curtis Hovey (sinzui) wrote :

I want a confirmation step just as we do with the assignment of a user to a bug who has never been assigned before. There is no way for the user to undo this operation.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r14003 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14003) is part of this bug's fix.

Changed in launchpad:
assignee: nobody → Steve Kowalik (stevenk)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → In Progress
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
MarcRandolph (mrand) wrote :

This can still result in orphaned bugs in Launchpad - that was my main point with Bug #503192.

If I unsubscribe myself (on purpose), and I am the last person subscribed to the bug, or if even if I'm not the last person, but the last person is inactive or a robot, the bug will be orphaned. Something akin to administrator access is needed as a backup.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Orphaned branches and bugs will be impossible soon. Users in project roles will have access without need of subcription--subscription will be about emails only.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14048 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14048>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.