No +activereviews page for Ubuntu

Bug #483931 reported by Jonathan Lange
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Laugh if you will, but many Ubuntu developers, particularly those in the Ubuntu Reviewers team, would like to be able to see all of the patches that are up for review on Ubuntu.

Ideally, the page would work in a very similar way to the +activereviews page for projects.

Jonathan Lange (jml)
tags: added: package-branches
Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 483931] Re: No +activereviews page for Ubuntu

At this stage, I don't forsee this happening for distributions as there is no
batching of any form on those pages.

Revision history for this message
James Westby (james-w) wrote :

Hi,

I disagree with the importance assigned to this bug.

We have a bunch of Ubuntu developers that would like to help integrate work
from other people. How do they find the list of outstanding reviews that they
could work on?

This problem is exacerbated by the lack of a good default review team for Ubuntu
(which I'm currently trying to fix).

Could we look at how to enable these people to get the information that they
need?

Thanks,

James

Revision history for this message
Tim Penhey (thumper) wrote :

On Wed, 09 Dec 2009 06:01:23 James Westby wrote:
> Hi,
>
> I disagree with the importance assigned to this bug.
>
> We have a bunch of Ubuntu developers that would like to help integrate work
> from other people. How do they find the list of outstanding reviews that
> they could work on?
>
> This problem is exacerbated by the lack of a good default review team for
> Ubuntu (which I'm currently trying to fix).
>
> Could we look at how to enable these people to get the information that
> they need?
>
> Thanks,
>
> James
>

My primary concern relates to the size of this page when dealing across the
over 180k package branches.

Revision history for this message
James Westby (james-w) wrote :

On Tue Dec 08 19:42:49 UTC 2009 Tim Penhey wrote:
> My primary concern relates to the size of this page when dealing across the
> over 180k package branches.

In terms of generating the page at all, or in terms of making it
so that people can find the things most relevant to them?

Thanks,

James

Revision history for this message
Jonathan Lange (jml) wrote :

A bit of both, I think. From an engineering PoV, we don't want to have a page that can practically grow without bound. That'll lead to timeouts, excessive server load etc.

From a user PoV, we don't want to have a page of possible things to do that can practically grow without bound. We already have something like that on the bug tracker, and it's not terribly popular :P

jml

Revision history for this message
James Westby (james-w) wrote :

On Wed Dec 09 05:30:33 UTC 2009 Jonathan Lange wrote:
> A bit of both, I think. From an engineering PoV, we don't want to have a
> page that can practically grow without bound. That'll lead to timeouts,
> excessive server load etc.

That's fair enough though. We need to be able to access the info. Imagine
if you were told that you weren't allowed to get the full list of bugs filed
against LP, except by individually querying the bugs filed against it by
every LP user in turn. Silly, I know, but we need this information.

That would probably cause more load anyway, as we do the loops to extract
the full list for display elsewhere.

> >From a user PoV, we don't want to have a page of possible things to do
> that can practically grow without bound. We already have something like
> that on the bug tracker, and it's not terribly popular :P

That we can work on. We have plans for LP external tools to help with things
like this. Some of the knowledge of that can feed back in to LP, and help
to design pages that show the user the most relevant things to them.

Thanks,

James

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Westby wrote:
> On Wed Dec 09 05:30:33 UTC 2009 Jonathan Lange wrote:
> That's fair enough though. We need to be able to access the info. Imagine
> if you were told that you weren't allowed to get the full list of bugs filed
> against LP, except by individually querying the bugs filed against it by
> every LP user in turn. Silly, I know, but we need this information.

I think you're assuming that +activereviews is only way to find this
information in bulk. For other branch listings, we have a +merges page
as well, which presents all the same code reviews as +activereviews (and
more), organized differently and with batching. I think that would be
much more suitable that +activereviews for this purpose.

> That would probably cause more load anyway, as we do the loops to extract
> the full list for display elsewhere.

In addition to load, +activereviews would cause database timeouts. Even
if we provided +activereviews, it's unlikely it would ever work.
Looping is bad, but it would actually work, so it would be better than
+activereviews.

>> >From a user PoV, we don't want to have a page of possible things to do
>> that can practically grow without bound. We already have something like
>> that on the bug tracker, and it's not terribly popular :P
>
> That we can work on. We have plans for LP external tools to help with things
> like this. Some of the knowledge of that can feed back in to LP, and help
> to design pages that show the user the most relevant things to them.

We have a per-user page also:
https://edge.launchpad.net/~james-w/+activereviews

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksft5cACgkQ0F+nu1YWqI1XuACfUHQE9MrQ5cTkWrg+iiv49Hdt
oCYAnj4SUO60h7uEDA9R93m6ie2UtKX3
=nJwT
-----END PGP SIGNATURE-----

Revision history for this message
James Westby (james-w) wrote :

On Wed Dec 09 14:43:38 UTC 2009 Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> James Westby wrote:
> > On Wed Dec 09 05:30:33 UTC 2009 Jonathan Lange wrote:
> > That's fair enough though. We need to be able to access the info. Imagine
> > if you were told that you weren't allowed to get the full list of bugs filed
> > against LP, except by individually querying the bugs filed against it by
> > every LP user in turn. Silly, I know, but we need this information.
>
> I think you're assuming that +activereviews is only way to find this
> information in bulk. For other branch listings, we have a +merges page
> as well, which presents all the same code reviews as +activereviews (and
> more), organized differently and with batching. I think that would be
> much more suitable that +activereviews for this purpose.

Does this page exist for Ubuntu? Where is it linked from?

> > That would probably cause more load anyway, as we do the loops to extract
> > the full list for display elsewhere.
>
> In addition to load, +activereviews would cause database timeouts. Even
> if we provided +activereviews, it's unlikely it would ever work.
> Looping is bad, but it would actually work, so it would be better than
> +activereviews.
>
> >> >From a user PoV, we don't want to have a page of possible things to do
> >> that can practically grow without bound. We already have something like
> >> that on the bug tracker, and it's not terribly popular :P
> >
> > That we can work on. We have plans for LP external tools to help with things
> > like this. Some of the knowledge of that can feed back in to LP, and help
> > to design pages that show the user the most relevant things to them.
>
> We have a per-user page also:
> https://edge.launchpad.net/~james-w/+activereviews

Yes, and I think this is actually the better way to find reviews. It doesn't
currently suit my needs fully though, as there isn't a "Reviews I can do."
That then doesn't work too well for package branches, partly because
of the way in which upload permissions are structured in Ubuntu. It would be
fantastic to fix that, which is what I was referring to.

Thanks,

James

Revision history for this message
Jonathan Lange (jml) wrote :

On Wed, Dec 9, 2009 at 10:10 PM, James Westby <email address hidden> wrote:
> On Wed Dec 09 05:30:33 UTC 2009 Jonathan Lange wrote:
>> A bit of both, I think. From an engineering PoV, we don't want to have a
>> page that can practically grow without bound. That'll lead to timeouts,
>> excessive server load etc.
>
> That's fair enough though. We need to be able to access the info. Imagine
> if you were told that you weren't allowed to get the full list of bugs filed
> against LP, except by individually querying the bugs filed against it by
> every LP user in turn. Silly, I know, but we need this information.
>

Agreed. To be clear, I don't think this bug should be "Wontfix". We
don't know how to do this in a nice way -- that doesn't mean we ought
to give up.

jml

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Westby wrote:
> On Wed Dec 09 14:43:38 UTC 2009 Aaron Bentley wrote:

>> I think you're assuming that +activereviews is only way to find this
>> information in bulk. For other branch listings, we have a +merges page
>> as well, which presents all the same code reviews as +activereviews (and
>> more), organized differently and with batching. I think that would be
>> much more suitable that +activereviews for this purpose.
>
> Does this page exist for Ubuntu? Where is it linked from?

No, it doesn't seem to exist for Ubuntu, but I think it would be
reasonable to add.

>> We have a per-user page also:
>> https://edge.launchpad.net/~james-w/+activereviews
>
> Yes, and I think this is actually the better way to find reviews. It doesn't
> currently suit my needs fully though, as there isn't a "Reviews I can do."

For me, that could be an overwhelming amount of information. Still, I
guess it's worth considering.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksgGd0ACgkQ0F+nu1YWqI3GSQCdHMOrLdL20tu0qchE23tNRm6h
ZiwAn2xhycY2+tYMRnet3HLiQRt2sQuS
=Uzx1
-----END PGP SIGNATURE-----

Revision history for this message
Tim Penhey (thumper) wrote :

On Wed, 09 Dec 2009 10:43:27 James Westby wrote:
> On Tue Dec 08 19:42:49 UTC 2009 Tim Penhey wrote:
> > My primary concern relates to the size of this page when dealing across
> > the over 180k package branches.
>
> In terms of generating the page at all, or in terms of making it
> so that people can find the things most relevant to them?

In terms of the potential number of reviews on that page.

Revision history for this message
James Westby (james-w) wrote :

On Wed Dec 09 21:42:56 UTC 2009 Aaron Bentley wrote:
> >> We have a per-user page also:
> >> https://edge.launchpad.net/~james-w/+activereviews
> >
> > Yes, and I think this is actually the better way to find reviews. It doesn't
> > currently suit my needs fully though, as there isn't a "Reviews I can do."
>
> For me, that could be an overwhelming amount of information. Still, I
> guess it's worth considering.

[ Getting a little off topic for this bug ]

I agree it would be a lot of information, but I also feel that I need
to be able to access it. Currently the only way to approximate this
is to trawl the +activereviews pages of projects I might review for
or teams I am in and pick from there.

Having a (paginated, sorted) list on my +activereviews page would avoid
having to go to lots of places, and reduces the changes that I miss
reviews for project X because they are rare and I neglect to go
there.

Even a list of links to projects which have outstanding requests where
a review is requested for a team I am in, so I can go to those pages
for the details would work.

Thanks,

James

Revision history for this message
Jonathan Lange (jml) wrote :

On Fri, Dec 11, 2009 at 9:08 AM, James Westby <email address hidden> wrote:
> Even a list of links to projects which have outstanding requests where
> a review is requested for a team I am in, so I can go to those pages
> for the details would work.
>

I like this idea.

Actually, you could have an +activereviews page for Ubuntu that was a bit like

|> aardvark (3 you must do; 6 you could do; 2 you're waiting on; 8 others)
|> bee (no reviews)
|> cacogen (...)

With each of the lines expanding to provide a traditional
+activereviews page. This would allow for pagination. James, would a
page like this be useful?

jml

Revision history for this message
Tim Penhey (thumper) wrote :

On Fri, 11 Dec 2009 14:49:37 Jonathan Lange wrote:
> On Fri, Dec 11, 2009 at 9:08 AM, James Westby <email address hidden>
wrote:
> > Even a list of links to projects which have outstanding requests where
> > a review is requested for a team I am in, so I can go to those pages
> > for the details would work.
>
> I like this idea.
>
> Actually, you could have an +activereviews page for Ubuntu that was a
> bit like
>
> |> aardvark (3 you must do; 6 you could do; 2 you're waiting on; 8 others)
> |> bee (no reviews)
> |> cacogen (...)
>
> With each of the lines expanding to provide a traditional
> +activereviews page. This would allow for pagination. James, would a
> page like this be useful?

Actually, without a lot of work, we can't do this, and it would be incredibly
slow. Unless we use a heap of ajax to make the page.

Revision history for this message
James Westby (james-w) wrote :

On Fri Dec 11 01:49:37 UTC 2009 Jonathan Lange wrote:
> On Fri, Dec 11, 2009 at 9:08 AM, James Westby <email address hidden> wrote:
> > Even a list of links to projects which have outstanding requests where
> > a review is requested for a team I am in, so I can go to those pages
> > for the details would work.
> >
>
> I like this idea.
>
> Actually, you could have an +activereviews page for Ubuntu that was a
> bit like
>
> |> aardvark (3 you must do; 6 you could do; 2 you're waiting on; 8 others)
> |> bee (no reviews)
> |> cacogen (...)
>
> With each of the lines expanding to provide a traditional
> +activereviews page. This would allow for pagination. James, would a
> page like this be useful?

That's the sort of thing we are heading towards with our external tool.

I'm not sure I would list packages that have no reviews.

I also think we should do better than alphabetic sorting. Putting things
you have reviewed for before higher, things you have uploaded lots higher,
etc. could be useful. Also, we have package sets, if you can upload to
a package set, push the members of that set higher. Push the ones
with more "must do" higer, followed by "could do."

That would start to work well for those that could upload fewer packages
I think. There would still be quite a big mass for those that could upload
everywhere though. Maybe just a "Random Review Request" button to click.

Thanks,

James

Revision history for this message
James Westby (james-w) wrote :

Hi,

There was just a discussion on the UDD list about the confusion arising
from the lack of this information.

Thanks,

James

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers