Commit message UI needs re-working

Bug #479526 reported by Martin Albisetti on 2009-11-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Tim Penhey

Bug Description

The commit message UI on merge proposals is confusing.

We need to re-work it. We shouldn't show edit icons for objects that are empty, so in this case the interaction would be something like:

(+) Set commit message -> inline editor comes up -> save -> profit

Once there is a commit message, the edit button is there.

And some bottom padding pretty please! :)

Related branches

lp:~thumper/launchpad/edit-commit-msg-link
Francis J. Lacoste (community): Approve (release-critical) on 2009-11-30
Māris Fogels (community): Approve (js) on 2009-11-30
Michael Hudson-Doyle: Abstain on 2009-11-27
Martin Albisetti (community): Approve (ui) on 2009-11-26
Guilherme Salgado: Pending requested 2009-11-27
Brad Crittenden (bac) wrote :

Also note that the in-line editor controls are broken for web-kit based browsers. The controls are placed incorrectly and occlude the entry area. See the attached screen shot.

Tim Penhey (thumper) on 2009-11-23
Changed in launchpad-code:
milestone: none → 3.1.11
Tim Penhey (thumper) on 2009-11-26
Changed in launchpad-code:
status: Triaged → In Progress
Tim Penhey (thumper) on 2009-12-09
Changed in launchpad-code:
milestone: 3.1.11 → 3.1.12
Tim Penhey (thumper) on 2009-12-13
Changed in launchpad-code:
status: In Progress → Fix Committed
Tim Penhey (thumper) on 2009-12-17
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments