oops leaving milestone code_name empty
Bug #475433 reported by
Curtis Hovey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Unassigned |
Bug Description
The OOPS-1405ED465 oops shows the NoneableTextLine is working with None, but it assumes it has a string.
* Module canonical.
super(
AttributeError: 'NoneType' object has no attribute 'strip'
The milestone code_name is optional. but is effectively required to avoid the oops.
This was not a problem last release when I edited milestones. The StrippedTextLin
Related branches
lp:~sinzui/launchpad/noneable-bug-475433
- Francis J. Lacoste (community): Approve (release-critical)
- Barry Warsaw (community): Approve (code)
-
Diff: 68 lines (+32/-6)2 files modifiedlib/canonical/launchpad/doc/stripped-text-widget.txt (+29/-4)
lib/canonical/launchpad/fields/__init__.py (+3/-2)
Changed in launchpad-registry: | |
assignee: | nobody → Curtis Hovey (sinzui) |
status: | Triaged → In Progress |
tags: | added: current-rollout-blocker |
Changed in launchpad-registry: | |
milestone: | 3.1.11 → 3.1.10 |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
On Thu, Nov 05, 2009 at 02:12:36PM -0000, Curtis Hovey wrote: e.set() method was added to by Tim's 2009-10-2 bmp- commit- message branch. It either needs to return early, or
> This was not a problem last release when I edited milestones. The
> StrippedTextLin
> inline-
> NoneableTextLine should test for None before calling super.
Don't forget to consider the case where the field is already set to some
non-None value, and you try to set it to None.
As a side note, we should replace the default TextLine widget with a
widget that always strips the input, so that we don't need to do this in
the field itself.