Rescuing a BUILDING builder just makes things worse
Bug #463046 reported by
William Grant
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Julian Edwards | ||
Bug Description
If rescueBuilderIfLost sees that the builder is still BUILDING, it will attempt to abort the build.
This is all well and good, except that there is nothing to actually clean up once the build is aborted. The only ABORTED status handler is in buildqueue, but rescueBuilderIfLost only does stuff when there is no buildqueue involved! So a rescue attempt on a wedged BUILDING builder just results in a wedged ABORTED builder instead.
Related branches
lp:~wgrant/launchpad/rescue-aborted-and-robbed-builders
- Canonical Launchpad Engineering: Pending requested
-
Diff: 311 lines (+191/-7) (has conflicts)4 files modifiedlib/lp/buildmaster/buildergroup.py (+86/-0)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+9/-1)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+74/-6)
lib/lp/soyuz/tests/soyuzbuilddhelpers.py (+22/-0)
lp:~julian-edwards/launchpad/lost-builder-bug-463046
- Henning Eggers (community): Approve (code)
-
Diff: 74 lines (+39/-1)2 files modifiedlib/lp/buildmaster/model/builder.py (+15/-1)
lib/lp/buildmaster/tests/test_builder.py (+24/-0)
Revision history for this message
| William Grant (wgrant) wrote | #1 |
| Changed in soyuz: | |
| status: | New → In Progress |
| assignee: | nobody → William Grant (wgrant) |
| Changed in soyuz: | |
| importance: | Undecided → High |
| Changed in soyuz: | |
| milestone: | none → 10.02 |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #2 |
| tags: | added: buildd-manager |
| Changed in soyuz: | |
| assignee: | William Grant (wgrant) → nobody |
| status: | In Progress → New |
| Changed in soyuz: | |
| status: | New → Triaged |
| Changed in soyuz: | |
| milestone: | 10.02 → none |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
| assignee: | nobody → William Grant (wgrant) |
| Changed in soyuz: | |
| assignee: | William Grant (wgrant) → nobody |
| status: | In Progress → Confirmed |
| Changed in soyuz: | |
| assignee: | nobody → Julian Edwards (julian-edwards) |
| status: | Confirmed → Triaged |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| Changed in soyuz: | |
| milestone: | none → 10.09 |
| tags: | added: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #5 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This probably rarely shows itself in practice (although I have a suspicion that it was behind the months of idling that gold did a few weeks back), since bug #463041 means that a build will not be rescued until it has finished on another builder, by which time it has probably finished on the first one too, so an abort would not be attempted.