Revisit buildd-monitor design
Bug #46295 reported by
Celso Providelo
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Invalid
|
Low
|
Unassigned |
Bug Description
As per bjorn comments, this code lacks tests and it's badly designed in some parts, like:
{{{
args= request[:1]
d=maybeDeferred
...
def cmd_reset(self, args)
}}}
We should something like this:
{{{
d = maybeDeferred(meth, *args)
...
def cmd_reset(self, build_id=None)
}}}
Changed in soyuz: | |
assignee: | Celso Providelo (cprov) → nobody |
visibility: | private → public |
tags: | added: bugjam2010 |
To post a comment you must log in.
Reduce the priority since the code is almost unnecessary in production.