Revisit buildd-monitor design

Bug #46295 reported by Celso Providelo
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Invalid
Low
Unassigned

Bug Description

As per bjorn comments, this code lacks tests and it's badly designed in some parts, like:

{{{
args= request[:1]
d=maybeDeferred(meth, args)
...
def cmd_reset(self, args)
}}}

We should something like this:

{{{
d = maybeDeferred(meth, *args)
...
def cmd_reset(self, build_id=None)
}}}

Revision history for this message
Celso Providelo (cprov) wrote :

Reduce the priority since the code is almost unnecessary in production.

Changed in launchpad-buildd:
assignee: nobody → cprov
status: Unconfirmed → Confirmed
Curtis Hovey (sinzui)
Changed in soyuz:
assignee: Celso Providelo (cprov) → nobody
Curtis Hovey (sinzui)
visibility: private → public
Revision history for this message
William Grant (wgrant) wrote :

buildd-monitor is gone.

Changed in soyuz:
status: Triaged → Invalid
tags: added: bugjam2010
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.