Error when a logged in tab attempts an action after another tab logs out

Bug #461321 reported by Brad Crittenden
40
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Using Safari, attempting to add a comment to an existing MP that I created resulted in an error pop-up with:

(, 'createComment', 'launchpad.AnyPerson')

I then attempted to create the same comment using Firefox and it succeeded. Moving back to Safari resulted in the same error.

Subsequently I have been able to add additional comments using Safari.

Revision history for this message
Brad Crittenden (bac) wrote :
tags: added: javascript
affects: launchpad → launchpad-code
Aaron Bentley (abentley)
tags: added: code-review
Changed in launchpad-code:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Leonard Richardson (leonardr) wrote :

I got this error when I tried to add a comment to a merge proposal without being logged in. The error indicates that you tried to do something you don't have permission for. The most likely explanation for Brad's problem is that he was logged into Launchpad in Firefox but not in Safari.

I think the best solution would be to hide the comment form altogether when the user is not logged in.

Revision history for this message
Brad Crittenden (bac) wrote :

Leonard when I visit a merge proposal while not logged in I see a comment "To post a comment you must log in." and there is no comment field. I'm not sure how you were able to see a comment box when not logged in. (I've been testing on staging.) Can you provide steps to reproduce it?

While your explanation is plausible I find it highly unlikely that I was not logged in, though there is no way to prove one way or the other. The good news is I have not seen the error since the original occurrence.

Revision history for this message
Tim Penhey (thumper) wrote :

Brad, is it possible that you logged out in a different tab?

Revision history for this message
Brad Crittenden (bac) wrote :

Tim it is possible that I had logged out of a different tab but 14 months later I really cannot recall.

Revision history for this message
Huw Wilkins (huwshimi) wrote :

Can we close this bug if it is unable to be reproduced?

Revision history for this message
Robert Collins (lifeless) wrote :

Well, we could, or we could try logging out in one tab and commenting in another. Meta: bug are evidence of defects, not the defect themselves; discarding bugs without figuring the cause means we'll just have to fight the defect another day.

Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
Curtis Hovey (sinzui)
summary: - Adding a comment to a merge proposal fails on 'createComment'
+ Error when a logged in tab attempts an action after another tab logs out
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.