Improvements to IBuilder.findBuildCandidate()

Bug #450124 reported by Michael Nelson on 2009-10-13
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Michael Nelson

Bug Description

With the fix for bug 393546 multiple builds for the same PPA+arch will only happen in series (to avoid builder monopolization by nightly builds for multiple distroarchserieses).

We may want to improve this solution so that, for example, builds with a score above a certain threshold will always be found as possible build candidates. This will allow, for example, security ppa builds for the same arch to be built in parallel.

This could be implemented in IBuilder._findBuildCandidate() in the clause that already ensures multiple builds for the same ppa+architecture are not considered concurrently, but IMO will require creating a new unit test to properly test (without making the doc test more complicated and less readable than it already is).

Related branches

description: updated
Julian Edwards (julian-edwards) wrote :

Initially, private archives should not be subject to the restriction implemented when fixing bug 393546. If we find more problems later then we can tweak the algorithm, but the current changes are a great start.

Changed in soyuz:
status: New → Triaged
importance: Undecided → High
milestone: none → 3.1.10
tags: added: soyuz-build
Changed in soyuz:
status: Triaged → In Progress
assignee: nobody → Michael Nelson (michael.nelson)
Michael Nelson (michael.nelson) wrote :

After chatting with Julian, we decided to simply ensure that private PPAs will not have the restriction of serial builds for an architecture.

I would have liked to use a score threshold instead - so that any PPA could put urgent builds through in parallel when needed, but the current scoring mechanism is very relative and setting a hard-coded score threshold (rather than a corresponding score label, such as 'urgent') isn't nice. Branch attached.

Changed in soyuz:
status: In Progress → Fix Committed
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers