"Propose for merging" link available, but says "Not allowed here" when followed if a default target branch is not viewable

[Gavin Panella]

I can see the link "Propose to merge" on:

  https://code.edge.launchpad.net/~mwhudson/lpbuildbot/jscheck-maturity

However, clicking on it results in:

  Not allowed here

  Sorry, you don't have permission to access this page.

  You are logged in as Gavin Panella.

  Traceback (most recent call last):

    * Module zope.publisher.publish, line 133, in publish
      result = publication.callObject(request, obj)
    * Module canonical.launchpad.webapp.publication, line 374, in callObject
      return mapply(ob, request.getPositionalArguments(), request)
    * Module zope.publisher.publish, line 108, in mapply
      return debug_call(obj, args)
      __traceback_info__: <security proxied zope.app.publisher.browser.viewmeta.SimpleViewClass from /srv/edge.launchpad.net/edge/launchpad-rev-9637/lib/lp/code/browser/../../app/templates/generic-edit.pt instance at 0x2aaab0620dd0>
    * Module zope.publisher.publish, line 114, in debug_call
      return obj(*args)
    * Module canonical.launchpad.webapp.publisher, line 281, in __call__
      self.initialize()
    * Module lp.code.browser.branch, line 1169, in initialize
      LaunchpadFormView.initialize(self)
    * Module canonical.launchpad.webapp.launchpadform, line 91, in initialize
      self.setUpWidgets()
    * Module canonical.launchpad.webapp.launchpadform, line 168, in setUpWidgets
      data=self.initial_values, adapters=self.adapters,
    * Module lp.code.browser.branch, line 1158, in initial_values
      reviewer = default_target.code_reviewer

  Unauthorized: (<Branch u'~launchpad-pqm/lpbuildbot/trunk' (38862)>, 'code_reviewer', 'launchpad.View')

No OOPS ID is given.

[Tim Penhey (thumper)]

On Tue, 06 Oct 2009 08:48:59 Gavin Panella wrote:
> Public bug reported:
>
> I can see the link "Propose to merge" on:
>
> https://code.edge.launchpad.net/~mwhudson/lpbuildbot/jscheck-maturity
>
> However, clicking on it results in:
>
> Not allowed here
>
> Sorry, you don't have permission to access this page.
>
> You are logged in as Gavin Panella.
>
> Traceback (most recent call last):
>
> * Module zope.publisher.publish, line 133, in publish
> result = publication.callObject(request, obj)
> * Module canonical.launchpad.webapp.publication, line 374, in
> callObject return mapply(ob, request.getPositionalArguments(), request) *
> Module zope.publisher.publish, line 108, in mapply
> return debug_call(obj, args)
> __traceback_info__: <security proxied
> zope.app.publisher.browser.viewmeta.SimpleViewClass from
> /srv/edge.launchpad.net/edge/launchpad-rev-9637/lib/lp/code/browser/../../
> app/templates/generic-edit.pt instance at 0x2aaab0620dd0> * Module
> zope.publisher.publish, line 114, in debug_call
> return obj(*args)
> * Module canonical.launchpad.webapp.publisher, line 281, in __call__
> self.initialize()
> * Module lp.code.browser.branch, line 1169, in initialize
> LaunchpadFormView.initialize(self)
> * Module canonical.launchpad.webapp.launchpadform, line 91, in
> initialize self.setUpWidgets()
> * Module canonical.launchpad.webapp.launchpadform, line 168, in
> setUpWidgets data=self.initial_values, adapters=self.adapters,
> * Module lp.code.browser.branch, line 1158, in initial_values
> reviewer = default_target.code_reviewer
>
> Unauthorized: (<Branch u'~launchpad-pqm/lpbuildbot/trunk' (38862)>,
> 'code_reviewer', 'launchpad.View')

Almost certainly this is due to the widget that selects which branch to land
on. You won't have permission to see the the trunk branch of lpbuildbot.

[Jonathan Lange (jml)]

If this is new in 3.0, I'd suggest marking it as post-3-ui-cleanup

[Tim Penhey (thumper)]

On Tue, 13 Oct 2009 23:19:07 Jonathan Lange wrote:
> If this is new in 3.0, I'd suggest marking it as post-3-ui-cleanup

It is not new, but it is polish.