Preview diff generation can die with unicode filenames
Bug #436794 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
Medium
|
Aaron Bentley | ||
| 2.0 |
Fix Released
|
Medium
|
Aaron Bentley | ||
| Launchpad itself |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
TransformPreview creates files according to their unicode filename. This means it can fail with 'ascii' codec can't encode character u'\\xed' in position 36: ordinal not in range(128) if the encoding isn't set.
In Launchpad, this causes oopses such as OOPS-1364UPD11
This sort of failure makes sense when creating a working tree, but not when creating a PreviewTree, which is virtual. This could be fixed by either naming files according to their trans_id, or by implementing an in-memory version of TransformPreview
Related branches
lp:~abentley/bzr/ascii-preview
- Vincent Ladeuil: Approve
-
Diff: 152 lines3 files modifiedNEWS (+3/-0)
bzrlib/tests/test_transform.py (+10/-0)
bzrlib/transform.py (+60/-39)
lp:~abentley/launchpad/parse-binary
- Francis J. Lacoste (community): Approve (release-critical)
- Brad Crittenden (community): Approve (code)
-
Diff: 55 lines3 files modifiedlib/lp/code/model/diff.py (+3/-1)
lib/lp/code/model/tests/test_diff.py (+5/-0)
versions.cfg (+3/-3)
| tags: | added: code-review |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in bzr: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| milestone: | none → 2.1.0b2 |
| status: | New → Fix Released |
| Changed in bzr: | |
| importance: | Undecided → Medium |
| Changed in launchpad: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
