Preview diff generation can die with unicode filenames

Bug #436794 reported by Aaron Bentley on 2009-09-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Medium
Aaron Bentley
2.0
Medium
Aaron Bentley
Launchpad itself
Medium
Unassigned

Bug Description

TransformPreview creates files according to their unicode filename. This means it can fail with 'ascii' codec can't encode character u'\\xed' in position 36: ordinal not in range(128) if the encoding isn't set.

In Launchpad, this causes oopses such as OOPS-1364UPD11

This sort of failure makes sense when creating a working tree, but not when creating a PreviewTree, which is virtual. This could be fixed by either naming files according to their trans_id, or by implementing an in-memory version of TransformPreview

Related branches

Aaron Bentley (abentley) on 2009-09-25
tags: added: code-review
Paul Hummer (rockstar) on 2009-10-10
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Medium
John A Meinel (jameinel) on 2009-11-02
Changed in bzr:
assignee: nobody → Aaron Bentley (abentley)
milestone: none → 2.1.0b2
status: New → Fix Released
Martin Pool (mbp) on 2009-11-25
Changed in bzr:
importance: Undecided → Medium
Changed in launchpad:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers