Approver logs spurious conflicts

Bug #435699 reported by Jeroen T. Vermeulen on 2009-09-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Critical
Jeroen T. Vermeulen

Bug Description

When an import queue entry matches multiple templates based on path and origin, the approver now logs a warning instead of crashing.

But it logs too many conflicts. Take this one for example:

Found 3 templates with path 'po/apt-all.pot' for package apt (0 matched on from_sourcepackagename).

Yes, there are 3 templates with that path for that package. But they're for 3 different distroseries!

The mistake is in POTemplateSet.getPOTemplateByPathAndOrigin. It compares productseries but not distroseries when looking for its matches. For distro packages, the productseries will always be null.

A consequence of this will be that uploads for these templates won't be auto-approved, which would be a problem for the Ubuntu folks.

Related branches

description: updated
Changed in rosetta:
milestone: 3.0 → 3.1.10
Jeroen T. Vermeulen (jtv) wrote :

Fixed in db-devel 8515

Changed in rosetta:
status: In Progress → Fix Committed
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers