Omissions in heading fixes for bug 431775
Bug #433989 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Jeroen T. Vermeulen |
Bug Description
While fixing bug 431775 (headings for translation group pages) I missed a few spots:
* The translation group +reassign page reuses its label as its page title. The title should be just "Change owner."
* The edit/remove pages for translation teams should have a breadcrumb for the language.
* Why does the remove page for translation teams have more breadcrumbs than the one for editing them?
Related branches
lp:~jtv/launchpad/bug-433989
Merged
into
lp:launchpad
- Eleanor Berger (community): Approve
-
Diff: 97 lines4 files modifiedlib/lp/translations/browser/configure.zcml (+0/-1)
lib/lp/translations/browser/language.py (+3/-12)
lib/lp/translations/browser/translationgroup.py (+6/-0)
lib/lp/translations/browser/translator.py (+5/-6)
Changed in rosetta: | |
status: | Triaged → In Progress |
tags: | added: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
У пон, 21. 09 2009. у 13:20 +0000, Jeroen T. Vermeulen пише:
> * The edit/remove pages for translation teams should have a
> breadcrumb for the language.
> * Why does the remove page for translation teams have more
> breadcrumbs than the one for editing them?
Very interesting, indeed. I believe it's because we are lacking the
language breadcrumb for ITranslator, and because +admin is the default
view (I assume the breadcrumbs code decides to get rid of the last
breadcrumb if we are on a default view, without checking that the last
breadcrumb was for the same view).