commit rejection is confusing
Bug #422274 reported by
Jonathan Lange
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
Launchpad's PQM requires commit messages to match a particular regex. We use this control to make sure:
* Changes have a reviewer
* Changes have had a UI review
* A patch has been approved for landing as "release critical"
* A patch fixes broken tests
Although they do a good job at actually matching it, the regexes generate terrible error messages when a commit message doesn't match them. Developers have been known to spend over an hour trying to figure out why they cannot land their branch.
Ideally, PQM would send errors that more closely match what we mean. e.g. "You must specify a UI reviewer."
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| summary: |
- PQM regex rejection emails are confusing + commit rejection is confusing |
Revision history for this message
| Gary Poster (gary) wrote | #1 |
To post a comment you must log in.
As a small change in this direction, I recently made the PQM regexes be commented with an indication of the broad issue.
ec2 test and bzr lp-land are closer to a real solution atm.