Launchpad bazaar branch notification emails should include revision id
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
Low
|
Unassigned |
Bug Description
In Launchpad one can subscribe to email notifications for when new revisions are pushed to a bazaar branch.
The email includes information like this:
X-Launchpad
revno: 2747
But the bazaar revision ids (revid:) are not included in the emails. This is a problem, as bazaar revision numbers are not stable, they can change anytime the branch is modified.
In particular, we use the notification emails to drive a Buildbot installation. But without the revision ids, the history gets confused whenever the revno: numbers change after a push.
More generally, there is no really reliable way to get from a notification email to the actual revision in a branch without
access to the revision ids.
Suggestion: include the revision ids in the notification emails, along with the revno: numbers.
I was going to say that this fix is trivial, but it actually involves changing the parameters to a bunch of functions.
I don't have a clear picture of how the stack fits together, but here's what I've found: bSource. create .create forRevision __init_ _
* IRevisionMailJo
* RevisionMailJob
* BranchMailer.
* BranchMailer.
and possibly others.
AIUI, these all would need to be changed to take the revision ID. Also, whatever is at the top of the stack (a scanner event?) would have to pass the revision ID in.
Not difficult per se, just quite a few places to change, and a bit of exploration to do.