Breadcrumbs code doesn't respect rootsite specified in zcml

Bug #418214 reported by Данило Шеган
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Guilherme Salgado

Bug Description

When a rootsite is specified with rootsite directive on browser:url in ZCML, the breadcrumbs should use that as the rootsite (instead of the hardcoded 'mainsite' value) passed to canonical_url()

(Ran into this when trying to add breadcrumbs to ITranslationGroupSet with a patch like http://pastebin.ubuntu.com/258759/: it resulted in the link being 'launchpad.dev/+groups' instead of 'translations.launchpad.dev/+groups')

Related branches

Changed in launchpad-foundations:
status: New → Triaged
description: updated
Revision history for this message
Guilherme Salgado (salgado) wrote :

Danilo, I'll have a fix for this up for review tomorrow, so you might want to delay landing your branch so that you don't need to duplicate the rootsite in the custom breadcrumb class.

Changed in launchpad-foundations:
assignee: nobody → Guilherme Salgado (salgado)
importance: Undecided → High
milestone: none → 2.2.8
status: Triaged → In Progress
Revision history for this message
Данило Шеган (danilo) wrote : Re: [Bug 418214] Re: Breadcrumbs code doesn't respect rootsite specified in zcml

У пон, 24. 08 2009. у 22:30 +0000, Guilherme Salgado пише:
> Danilo, I'll have a fix for this up for review tomorrow, so you might
> want to delay landing your branch so that you don't need to duplicate
> the rootsite in the custom breadcrumb class.

Cool, I'll wait for it to land and then merge with it before landing my
branch.

Revision history for this message
Guilherme Salgado (salgado) wrote :

Danilo, you'll also need to rename BreadcrumbBuilder with Breadcrumb in your branch as I got rid of the former, replacing it with the latter.

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r9230.

Changed in launchpad-foundations:
status: In Progress → Fix Committed
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.