Conform heading and breadcrumb rules to UI 3.0

Bug #417089 reported by Curtis Hovey on 2009-08-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Barry Warsaw

Bug Description

For IPrimaryContext, the default creation of a <h2> should not happen because it will not have breadcrumbs. The slot should honour the template if a heading is passed to it.

Related branches

Curtis Hovey (sinzui) wrote :

Michael had these thoughts:
    So the heading slot always defaults to displaying <h2>context.title</h2>,
    with only the following two exceptions:

    1. if the current context is an IPrimaryContext, then the whole
    heading-slot+breadcrumbs will not display (as per sinzui's suggestion).

    2. if the current context is not an IPrimaryContext but we are viewing
    the index of the current context then it will default to an h1:
    <h1>context.title</h1>

    If and only if you need an inline-editable widget do you need to fill
    the heading slot - and in fact, we could call it something more obvious
    in this case 'inline_edit_heading_widget' so people are very aware when
    filling it.

Barry Warsaw (barry) on 2009-08-31
Changed in launchpad-foundations:
assignee: Curtis Hovey (sinzui) → Barry Warsaw (barry)
Barry Warsaw (barry) on 2009-09-01
Changed in launchpad-foundations:
status: Triaged → In Progress
Barry Warsaw (barry) on 2009-09-03
description: updated
Barry Warsaw (barry) wrote :

After extensive discussion with Martin, the headings and breadcrumb rules are defined here:

https://dev.launchpad.net/VersionThreeDotO/UI/Conversion#Heading%20rules

summary: - the base-layout heading-slot should not render any heading for
- IPrimaryContext
+ Conform heading and breadcrumb rules to UI 3.0
Barry Warsaw (barry) on 2009-09-12
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Barry Warsaw (barry) on 2009-09-24
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers