PPA Buildd emails are missing a rationale message
Bug #410893 reported by
Māris Fogels
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Colin Watson |
Bug Description
PPA Buildd system emails should have a rationale message following them, so I can sort the emails using the message text. (I am using Gmail, and Gmail does not support filtering on custom mail headers.)
All other emails have a rationale: Question mails, Bug mails, etc.
Related branches
lp:~cjwatson/launchpad/separate-build-notifications
- William Grant (community): Approve (code)
-
Diff: 537 lines (+180/-108)4 files modifiedlib/lp/soyuz/doc/build-failedtoupload-workflow.txt (+17/-1)
lib/lp/soyuz/emailtemplates/build-notification.txt (+2/-0)
lib/lp/soyuz/model/binarypackagebuild.py (+18/-13)
lib/lp/soyuz/tests/test_build_notify.py (+143/-94)
Changed in launchpad: | |
importance: | Medium → High |
tags: | added: notifications |
Changed in launchpad: | |
assignee: | nobody → Colin Watson (cjwatson) |
status: | Triaged → In Progress |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This should be a trivial fix:
1) Write a test to verify the rational message's presence
2) Update the buildd mail template
Is anyone willing to sponsor the fix?
Root cause analysis:
Why doesn't this mail have a rational? Including a rational is part of our design guidelines, but it should be added by the mail notification system templates automatically, shouldn't it?