Code acceptance tests fail when system bzr is used

[Björn Tillenius]

As seen in http://buildbot.devpad.info/builders/db_lp/builds/573, a lot of code tests failed, since the bzr executable couldn't be found. The reason for this was that the system bzr in the builder was updated to 1.17, so it was used instead of the egg. The code that gets the path to bzr doesn't handle that situation.

Is bzr ever executed in non-test code? If so, we need to make sure that production isn't affected by this problem the next time a rollout is done, or the system bzr updated.

[Gary Poster (gary)]

One approach is to try to make a buildout option to ignore specific system eggs for specific packages (a blacklist). (Maybe a whitelist would be better. There is already an option to ignore all system eggs, but we can't use it because we actually want some of them.) I may try to add this, because it sounds like a reasonable feature for us and I think I see how to do it.

However, if this is merely a test fragility, it would be nice for you all to also address things on your end.

[Michael Hudson-Doyle (mwhudson)]

We need to know where the bzr executable is for production too, so we need a 'real fix' for this.

[Jonathan Lange (jml)]

AIUI, the bug isn't actually that the tests fail when we use the system bzr -- that's expected. The bug is that the tests use the system bzr.

[Gary Poster (gary)]

OK, this is not a test fragility then, and AIUI the buildout fix is the necessary change. I'll try to do this today. I'll leave this bug in launchpad-code in case you think that there is an additional change needed on your side. If not (that is, the buildout change is sufficient) just assign it to me.

Thanks