ExpatError errors should be handled to not generate the OOPSes
Bug #403606 reported by
Ursula Junque
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Barry Warsaw |
Bug Description
As we can see in OOPS-1300XMLP5, invalid requests generate oopses like:
ExpatError: not well-formed (invalid token): line 33, column 3521
We need to find a way to deal better with the noise.
More: OOPS-1306XMLP2, OOPS-1306XMLP20
Related branches
lp:~barry/launchpad/403606-expat
Merged
into
lp:launchpad
- Paul Hummer (community): Approve (code)
- Canonical Launchpad Engineering: Pending requested
-
Diff: 278 lines9 files modifiedlib/canonical/launchpad/mailman/monkeypatches/lpmoderate.py (+2/-1)
lib/canonical/launchpad/webapp/publication.py (+1/-1)
lib/canonical/launchpad/webapp/servers.py (+1/-0)
lib/canonical/launchpad/xmlrpc/mailinglist.py (+11/-2)
lib/lp/registry/doc/mailinglist-xmlrpc.txt (+7/-6)
lib/lp/registry/doc/message-holds-xmlrpc.txt (+50/-1)
lib/lp/registry/interfaces/mailinglist.py (+2/-2)
lib/lp/services/mailman/doc/create-lists.txt (+2/-2)
lib/lp/services/mailman/doc/postings.txt (+32/-0)
description: | updated |
Changed in launchpad-registry: | |
milestone: | 2.2.8 → 3.0 |
Changed in launchpad-registry: | |
milestone: | 3.0 → 3.1.10 |
Changed in launchpad-registry: | |
status: | Triaged → In Progress |
Changed in launchpad-registry: | |
status: | In Progress → Fix Committed |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
(Thanks to Francis for the diagnosis)
This seems to be a problem with an internal mailman process talking to our xmlrpc server (see "PATH_INFO: /mailinglists" in the OOPSes). In this case, the OOPS is valuable, in that it indicates something going wrong in our internal communications.
This means that the bug should go to registry; and that the expat errors in these oopses actually are not noise.