ExpatError errors should be handled to not generate the OOPSes

Bug #403606 reported by Ursula Junque on 2009-07-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Barry Warsaw

Bug Description

As we can see in OOPS-1300XMLP5, invalid requests generate oopses like:

  ExpatError: not well-formed (invalid token): line 33, column 3521

We need to find a way to deal better with the noise.

More: OOPS-1306XMLP2, OOPS-1306XMLP20

Related branches

Ursula Junque (ursinha) on 2009-07-30
description: updated
Gary Poster (gary) wrote :

(Thanks to Francis for the diagnosis)

This seems to be a problem with an internal mailman process talking to our xmlrpc server (see "PATH_INFO: /mailinglists" in the OOPSes). In this case, the OOPS is valuable, in that it indicates something going wrong in our internal communications.

This means that the bug should go to registry; and that the expat errors in these oopses actually are not noise.

affects: launchpad-foundations → launchpad-registry
Curtis Hovey (sinzui) wrote :

Barry. Can you look into what could be causing this? I cannot think of anything we have done recently to cause ill-formed markup. Since the other oopses regarding mailman have gone away, I wonder if debuging information is getting into the XML.

Changed in launchpad-registry:
assignee: nobody → Barry Warsaw (barry)
importance: Undecided → High
milestone: none → 2.2.8
status: New → Triaged
Barry Warsaw (barry) wrote :

I actually don't think it's anything we're doing wrong. I think we're getting intermittent partial data. In the daily reports, I see a handful of these a week, definitely not every day.

I think we'd have to add some debugging output to catch the exception and print the received XML to diagnose this further. My suspicion is intermittent networking issues. It's probably worth spending some time debugging.

On Thu, 2009-08-20 at 15:26 +0000, Barry Warsaw wrote:
> I actually don't think it's anything we're doing wrong. I think we're
> getting intermittent partial data. In the daily reports, I see a
> handful of these a week, definitely not every day.

Do these relate the Connection refused errors we see in the oopses?

Curtis Hovey (sinzui) on 2009-08-21
Changed in launchpad-registry:
milestone: 2.2.8 → 3.0
Barry Warsaw (barry) on 2009-09-18
Changed in launchpad-registry:
milestone: 3.0 → 3.1.10
Barry Warsaw (barry) on 2009-09-30
Changed in launchpad-registry:
status: Triaged → In Progress
Barry Warsaw (barry) wrote :

This is heartwarming.

The oops are coming from holdMessage() and they almost all spam. So the good news may be that this can be fixed. The bad news is that it'll probably increase the amount of spam moderators have to deal with :(

Barry Warsaw (barry) on 2009-10-01
Changed in launchpad-registry:
status: In Progress → Fix Committed
Barry Warsaw (barry) on 2009-11-05
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers