log local var clobbered in lib/lp/services/mail/incoming.py

[Gavin Panella]

The log variable, initialised around line 180, inside handleMail()
before the main processing loop, gets clobbered in a few places within
the loop. I think this is unlikely to be desired behaviour, though it
doesn't seem to be causing problems right now.

{{{
    log = getLogger('process-mail')
...
        for mail_id, raw_mail in mailbox.items():
            log.info("Processing mail %s" % mail_id)
...
                try:
                    mail = signed_message_from_string(raw_mail)
                except email.Errors.MessageError, error:
                    mailbox.delete(mail_id)
                    log = getLogger('canonical.launchpad.mail')
}}}

[Colin Watson (cjwatson)]

This appears to have been fixed in r12990.