Show if a branch is broken in links to that branch

[Robert Collins]

when a branch is bong, the branch page shows a green warning. An icon
that something is wrong would be a great hint to show where a link to
that branch is shown, as often folk doing merge reviews etc won't follow
the link, but a stale or damaged branch is important to know about.

-Rob

 affects launchpad-code

--

[Jonathan Lange (jml)]

We currently have an icon (known internally as a 'badge') for broken branches that's used in all of our branch listings. It's not used for links in general, and like all of the other badges, it's not use on the code review page or code review listing pages.

I'm not sure it's a good idea to incorporate the broken badge into the link for branches. Martin Albisetti would have to comment on that. Certainly I think that if we do fix this bug, the fix should take place in the fmt:link handler for Branch.

Bouncing to beuno for UI thoughts, which are needed before proceeding further.

[Martin Albisetti (beuno)]

How bad would it look if we had the warning icon next to the branch icon for broken branches?

[Jonathan Lange (jml)]

On Thu, Jul 16, 2009 at 10:16 PM, Martin Albisetti<email address hidden> wrote:
> How bad would it look if we had the warning icon next to the branch icon
> for broken branches?
>

Probably not _that_ bad. If you reckon it's a good idea I can whip up
a screenshot sometime next week.

jml

[Jonathan Lange (jml)]

beuno has come up with a draft UI change -- that gives us something to work with.