Marking a branch as 'Abandoned' should cancel any merge proposals

[Jonathan Lange]

When I mark a branch as abandoned, that means I don't want to merge it anywhere.
Not sure what the UI for this should look like, given that it's probably a good idea to include some text on the merge proposals saying why the branch is abandoned.

[Tim Penhey (thumper)]

On Tue, 14 Jul 2009 10:55:07 Jonathan Lange wrote:
> Public bug reported:
>
> When I mark a branch as abandoned, that means I don't want to merge it
> anywhere. Not sure what the UI for this should look like, given that it's
> probably a good idea to include some text on the merge proposals saying why
> the branch is abandoned.

We don't have an "abandoned" state on merge proposals right now.

Any suggestions?

[Jonathan Lange (jml)]

Here are a few:
  - add an abandoned state to merge proposals
  - remove the lifecycle_status column completely and make branch status a derived field based on the status of its merge proposals, among other things
  - delete the merge proposal when a branch is marked as abandoned

[Martin Pool (mbp)]

2009/7/20 Jonathan Lange <email address hidden>:
> Here are a few:
>  - add an abandoned state to merge proposals

To me 'abandoned' is not quite the right word here because it means
something more like 'neglected' than 'cancelled'. How about
'withdrawn'?

>  - remove the lifecycle_status column completely and make branch status a derived field based on the status of its merge proposals, among other things

That would be a nice step.

>  - delete the merge proposal when a branch is marked as abandoned

I think it should remain available on the web, though less
prominently. Reading about abandoned/withdrawn proposals is useful to
learn from previous mistakes. Obviously there must be a 'really
delete' for some situations.

--
Martin <http://launchpad.net/~mbp/>

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> 2009/7/20 Jonathan Lange <email address hidden>:
>> Here are a few:
>> - add an abandoned state to merge proposals
>
> To me 'abandoned' is not quite the right word here because it means
> something more like 'neglected' than 'cancelled'. How about
> 'withdrawn'?

I think we already have 'withdrawn': rejected by proposer.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpkanMACgkQ0F+nu1YWqI2lSwCeMjADfP49fbpuaG7M3KrDIEGQ
OPgAnjl0OgnIPVcPkmJTdDOcmXMn+bSP
=1uca
-----END PGP SIGNATURE-----

[Tim Penhey (thumper)]

On Tue, 21 Jul 2009 01:00:38 Aaron Bentley wrote:
> Martin Pool wrote:
> > 2009/7/20 Jonathan Lange <email address hidden>:
> >> Here are a few:
> >> - add an abandoned state to merge proposals
> >
> > To me 'abandoned' is not quite the right word here because it means
> > something more like 'neglected' than 'cancelled'. How about
> > 'withdrawn'?
>
> I think we already have 'withdrawn': rejected by proposer.
>
> Aaron

Semantically I think 'withdrawn' and 'rejected' are quite different.

[Jonathan Lange (jml)]

On Tue, Jul 21, 2009 at 10:06 AM, Tim Penhey<email address hidden> wrote:
> On Tue, 21 Jul 2009 01:00:38 Aaron Bentley wrote:
>> Martin Pool wrote:
>> > 2009/7/20 Jonathan Lange <email address hidden>:
>> >> Here are a few:
>> >>  - add an abandoned state to merge proposals
>> >
>> > To me 'abandoned' is not quite the right word here because it means
>> > something more like 'neglected' than 'cancelled'.  How about
>> > 'withdrawn'?
>>
>> I think we already have 'withdrawn': rejected by proposer.
>>
>> Aaron
>
> Semantically I think 'withdrawn' and 'rejected' are quite different.
>

If I'm proposing it, then "rejected by me" isn't much different from
"withdrawn".

However, I would probably never think to actually choose 'rejected' to
mean 'I withdraw this'.

jml

[Mathias Gug (mathiaz)]

This feature would be helpful for the following merge proposal:

https://code.launchpad.net/~clint-fewbar/ubuntu/maverick/cloud-init/glusterfs-mount-example

I'd like to mark the merge proposal/branch as abandoned as I want to have the proposal removed from my list of +activereviews.

However I don't want to delete the merge proposal as I'd like to keep a trace of the proposal.