Re-entering a rejected suggestion dismisses it silently

Bug #392147 reported by Henning Eggers
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Once a suggestion has been rejected, either by choosing a different suggestion as the current translation or by using the "dismiss suggestions" checkbox, it cannot be entered again. So if another user comes by and makes the same suggestion again, not being aware that it was rejected before, the suggestion just seems to go into /dev/null. No change is visible in the UI.

Instead, the user should be informed about what is happening.
"This suggestion has been made been made before but has already been reviewed and rejected. Please ask one of the reviewers to go over all obsolete translations to activate it anyway."

Revision history for this message
Данило Шеган (danilo) wrote :

Note that this will have to happen after we provide a listing of obsolete suggestions in a zoomed in view, when we can also provide a link people can give to reviewers.

tags: added: ui
Changed in rosetta:
importance: Undecided → Medium
status: New → Triaged
Changed in rosetta:
milestone: none → 2.2.9
Revision history for this message
Matthew Revell (matthew.revell) wrote :

Retargeting to 3.0, which is the new name for 2.2.9. Haven't renamed the milestone as the 3.0 milestone is in a different series.

Changed in rosetta:
milestone: 2.2.9 → 3.0
Changed in rosetta:
milestone: 3.0 → 2.2.8
Changed in rosetta:
milestone: 2.2.8 → none
Revision history for this message
Adi Roiban (adiroiban) wrote :

For reference:
18:54 danilos : adiroiban, if you ever want to fix that, you'll have to provide a new method addASuggestion() or something,
                   similar to what you did for this bug, and move the functionality out of updateTranslation method and add
                   new functionality you want :)
18:54 danilos : adiroiban, and again, moved the logic to decide what to do out into browser code

Changed in rosetta:
assignee: nobody → Adi Roiban (adiroiban)
Adi Roiban (adiroiban)
Changed in rosetta:
assignee: Adi Roiban (adiroiban) → nobody
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.