Launchpad itself

Cancel button on +validatesignonlygpg useless

Bug #391630 reported by Matthew Revell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Guilherme Salgado
Launchpad itself 3.1.10

Bug Description

The cancel button on +validatesignonlygpg still requires that you enter something in the text box, and so is kinda useless.

Revision history for this message
Curtis Hovey (sinzui) wrote :

This must switch to the standard cancel link.

Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
tags: added: trivial
Curtis Hovey (sinzui)
tags: added: post-3-ui-cleanup
Changed in launchpad-registry:
milestone: none → 3.1.10
Revision history for this message
Curtis Hovey (sinzui) wrote :

This cannot be switched to a cancel link because the button is consuming the logintoken. I think the validation rules need refactoring. The gpg/gpgsignonly rules are stepping on the cancel rules. I suspect the correct fix is to replace the validation method with two independent validators setup in the each action. It may be possible to check of the user is trying to cancel as the first step in validation and return immediately.

Changed in launchpad-registry:
milestone: 3.1.10 → 3.1.11
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Triaged → In Progress
assignee: nobody → Curtis Hovey (sinzui)
Revision history for this message
Curtis Hovey (sinzui) wrote :

This was implicitly fixed by recent refactorings.

Changed in launchpad-registry:
assignee: Curtis Hovey (sinzui) → Guilherme Salgado (salgado)
milestone: 3.1.11 → 3.1.10
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.