The current implementation of RevisionAuthorEmailLinker in garbo.py does not evenly distribute work, causingsome transactions to run of 80 or 90 seconds. It is also very inefficient.
A better implementation would be to calculate the set of linkable RevisionAuthor records, storing them in a temporary table. We can then perform the updates in chunks.
In __init__:
CREATE TEMPORARY TABLE LinkableRevisionAuthor (
id serial PRIMARY KEY,
revision_author integer,
person integer);
INSERT INTO LinkableRevisionAuthor (revision_author, email_address)
SELECT RevisionAuthor.id, EmailAddress.person
WHERE RevisionAuthor.person IS NULL
AND lower(RevisionAuthor.email) = lower(EmailAddress.email)
In __call__:
UPDATE RevisionAuthor
SET RevisionAuthor.person = LinkableRevisionAuthor.person
USING (
SELECT revision_author, person
FROM LinkableRevisionAuthor
WHERE id BETWEEN self.offset AND self.offset + chunk_size
) AS LinkableRevisionAuthor
Hi Stuart,
If this hasn't yet been done, or won't be done for 3.0, can you kick it to 3.1.10 please?