test/dev librarian work area not kept in sync by make schema etc

[Brad Bollenbach]

I just tried to do an upload in the librarian (at http://localhost:8086/products/firefox/+bug/1/+addattachment) on localhost and got this error:

2005/11/03 17:48 EST [-] Traceback (most recent call last):
          File "/usr/lib/python2.4/threading.py", line 422, in run
            self.__target(*self.__args, **self.__kwargs)
          File "/usr/lib/python2.4/site-packages/twisted/python/threadpool.py", line 145, in _worker
            context.call(ctx, function, *args, **kwargs)
          File "/usr/lib/python2.4/site-packages/twisted/python/context.py", line 52, in callWithContext
            return self.currentContext().callWithContext(ctx, func, *args, **kw)
          File "/usr/lib/python2.4/site-packages/twisted/python/context.py", line 31, in callWithContext
            return func(*args,**kw)
        --- <exception caught here> ---
          File "/usr/lib/python2.4/site-packages/twisted/internet/threads.py", line 25, in _putResultInDeferred
            result = f(*args, **kwargs)
          File "/home/bradb/canonical/malone-ubz-fixes/lib/canonical/librarian/storage.py", line 109, in store
            self._move(contentID)
          File "/home/bradb/canonical/malone-ubz-fixes/lib/canonical/librarian/storage.py", line 129, in _move
            raise DuplicateFileIDError(fileID)
        canonical.librarian.storage.DuplicateFileIDError: 37

In speaking with spiv and jamesh, this appears to be related to the librarian directory not being properly cleared out when the database gets reset.

[Michael Hudson-Doyle (mwhudson)]

This seems to be in the same class of bug as the branch sample data in the db not corresponding to actual branches on the filesystem; maybe make schema should do some file system frobbing as well (create some branches, create some librarian files, as well as deleting now unreferenced data of the same kind)?

[Robert Collins (lifeless)]

As we proceed with eliminationing sample data the problem here will shrink. We may well want to have make schema nuke the dev librarian work area though.