changes to branches up for review should be sent to reviewers

[Robert Collins]

 affects launchpad-code

e.g
write some code
submit
reviewer says 'do x', review disapprove
author says 'ok'
author pushes new code
reviewer should see either a diff of the new work, or a new preview, or
something.

or perhaps the author needs a way to say 'tell people now'.

Anyhow, at the moment we're getting desynced between reviewer and author
with the latter having done the work and the former unaware.

-Rob

[Tim Penhey (thumper)]

I agree entirely.

I was wanting to have some form of review diff updating and some form of
interdiff too.

[Aaron Bentley (abentley)]

I think "resubmit" is the "tell people now" button, and we just need to make it nicer.

[Robert Collins (lifeless)]

On Fri, 2009-06-12 at 20:17 +0000, Aaron Bentley wrote:
> I think "resubmit" is the "tell people now" button, and we just need to
> make it nicer.

If so thats fine, but please be sure to document it - as an author I
wouldn't naturally think of using a reviewers button to notify other
reviewers that I've made a requested change. And if there are
permissions added to reviews at any point we'll need to make sure that
authors can always hit resubmit..

-Rob