default review team should show whether it is subscribed

Bug #375218 reported by Robert Collins on 2009-05-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Unassigned

Bug Description

This is related to my adjacent bug filing about whether I am subscribed.
As a project lead I may assign a team to review a branch. If I do that
its not obvious that I *also* need to subscribe the team to the branch.

I suggest showing the status of the subscription for the default
reviewer inline, or something.

 affects launchpad-code
--

Martin Albisetti (beuno) wrote :

Actually, it should subscribe the reviewer by default. There's a bug about that around somewhere which I can't find.

On Tue, 2009-05-12 at 03:47 +0000, Martin Albisetti wrote:
> Actually, it should subscribe the reviewer by default. There's a bug
> about that around somewhere which I can't find.

What if it does, but all the branches from before reviews don't ave it
subscribed?

Martin Pool (mbp) wrote :

What beuno said would be consistent with bugs, I think.

Tim Penhey (thumper) wrote :

On Tue, 12 May 2009 15:47:20 Martin Albisetti wrote:
> Actually, it should subscribe the reviewer by default. There's a bug
> about that around somewhere which I can't find.

There was a bug and I think it was set to Won't Fix.

Right now we aren't emailing reviewers if they are teams as some people were
setting the ubuntu developers as the review team and spamming everyone.

This was a policy decision that we made at the time.

Individual's that are reviewers on the proposal do get emails sent directly to
them even if they are not subscribed to either the source or the target
branch.

Robert Collins (lifeless) wrote :

On Sun, 2009-05-17 at 20:31 +0000, Tim Penhey wrote:
> On Tue, 12 May 2009 15:47:20 Martin Albisetti wrote:
> > Actually, it should subscribe the reviewer by default. There's a bug
> > about that around somewhere which I can't find.
>
> There was a bug and I think it was set to Won't Fix.
>
> Right now we aren't emailing reviewers if they are teams as some people were
> setting the ubuntu developers as the review team and spamming everyone.

AIUI package branches are getting a special behaviour for ubuntu-dev and
ubuntu-core-dev, this would mean this special case isn't needed.

> This was a policy decision that we made at the time.
>
> Individual's that are reviewers on the proposal do get emails sent directly to
> them even if they are not subscribed to either the source or the target
> branch.

Yes they do. But no one knows that in this one special case launchpad
behaves differently vis-a-vis the contact. The general theme is 'team as
bug contact, team gets contacted', etc.

-Rob

Tim Penhey (thumper) wrote :

On Mon, 18 May 2009 09:52:34 Robert Collins wrote:
> Yes they do. But no one knows that in this one special case launchpad
> behaves differently vis-a-vis the contact. The general theme is 'team as
> bug contact, team gets contacted', etc.
>
> -Rob

We could do a project wide review team, kinda like the bug contact.

We'd probably want something like that too for distro/sourcepackage.

Jonathan Lange (jml) wrote :

Tim, I guess we need to talk about this and sort out what needs to be done.

tags: added: subscription
Changed in launchpad-code:
assignee: nobody → Tim Penhey (thumper)
status: New → Incomplete
Tim Penhey (thumper) wrote :

Yes, I agree, we should show this. We should also rename "Default review team" to just "Review team" at the same time.

Changed in launchpad-code:
assignee: Tim Penhey (thumper) → nobody
importance: Undecided → High
milestone: none → 2.2.7
status: Incomplete → Triaged
Tim Penhey (thumper) on 2009-07-17
Changed in launchpad-code:
milestone: 2.2.7 → 2.2.9
Matthew Revell (matthew.revell) wrote :

Retargeting to 3.0, which is the new name for 2.2.9. Haven't renamed the milestone as the 3.0 milestone is in a different series.

Changed in launchpad-code:
milestone: 2.2.9 → 3.0
Tim Penhey (thumper) on 2009-09-18
Changed in launchpad-code:
milestone: 3.0 → 3.1.10
Tim Penhey (thumper) wrote :

It kinda sucks that this hasn't been done yet, but I do think it is important and I'm loathed to completely untarget, so pushing off again and adding tags.

Changed in launchpad-code:
assignee: nobody → Tim Penhey (thumper)
milestone: 3.1.10 → 3.1.11
tags: added: post-3-ui-cleanup
Tim Penhey (thumper) wrote :

Here is a quick mockup

Martin Pool (mbp) wrote :

The mockup of #11 does explain the situation but without a link to this bug (or the same explanation in a FAQ) I think it would just leave people wondering "OK, but why? And what do I do now?"

Perhaps you need to go back to considering or explaining what it means to have a reviewer assigned to a branch.

As a starting point, if a person or team is going to be assigned as a reviewer, they ought to be told about reviews they need to do.

If a team is never appropriate to assign as a reviewer (as may be the case for ubuntu-devel?) then you need to address that problem, not just not send mail. This could be addressed by eg investigating what people are trying to do when they request the review, or why they don't find a more appropriate reviewer, or having a per-team bit saying "willing to do code reviews or not."

If a person is willing to do reviews but they want to poll Launchpad rather than getting mail then that seems to need some kind of notification preference.

Tim Penhey (thumper) on 2009-12-09
Changed in launchpad-code:
milestone: 3.1.11 → none
Robert Collins (lifeless) wrote :

@Tim are you still working on this? You're still assigned, but I see you removed the milestone. Perhaps it should be lower priority ?

Tim Penhey (thumper) wrote :

On Fri, 19 Nov 2010 17:26:10 you wrote:
> @Tim are you still working on this? You're still assigned, but I see you
> removed the milestone. Perhaps it should be lower priority ?

No, not actively working on it.

Changed in launchpad-code:
assignee: Tim Penhey (thumper) → nobody
huwshimi (huwshimi) on 2011-04-07
tags: added: ui
removed: post-3-ui-cleanup
Robert Collins (lifeless) wrote :

I've tagged this email notifications because its largely a bug about confusion arising from code reviews behaving inconsistently with the rest of LP as far as when to send emails (see the discussion above).

tags: added: email notifications
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers