Don't log OOPSes when people try to delete a directory
Bug #372506 reported by
Jonathan Lange
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Michael Hudson-Doyle | ||
Bug Description
If a user tries to delete (as opposed to rmdir) a directory on the SSH server, we log an OOPS with a wrapped version of the underlying OS error. There's no need to log OOPSes here at all, the error is of the same category as "file not found".
See OOPS-1221SMPSSH3 for an example:
TransportError: Transport error: [Errno 21] Is a directory: ...
Related branches
lp:~mwhudson/launchpad/dont-oops-sftp-unlink-directory-bug-372506
- Paul Hummer (community): Approve
-
Diff: 29 lines2 files modifiedlib/lp/codehosting/sftp.py (+1/-0)
lib/lp/codehosting/tests/test_sftp.py (+7/-0)
| description: | updated |
| Changed in launchpad-code: | |
| assignee: | nobody → Michael Hudson (mwhudson) |
| milestone: | none → 3.1.10 |
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | #1 |
| Changed in launchpad-code: | |
| status: | Triaged → Fix Committed |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
launchpad/devel r9805