Launchpad itself

Code overview page offers to let you "browse source code", but takes you to revision browser

Bug #369273 reported by James Westby on 2009-04-29
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
​ Launchpad itself
Fix Released
Low
Jonathan Lange
Launchpad itself 3.1.10
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

Take

  https://code.edge.launchpad.net/bzr

it says

  You can browse the source code for the development focus branch ...

with "browse the source code" linking to

  http://bazaar.launchpad.net/~bzr/bzr/trunk/changes

which is more like "browse the history". It is also inconsistent with what
"Source Code" takes you to from the development branch's branch page.

I think it should link to

  http://bazaar.launchpad.net/~bzr/bzr/trunk/files

instead.

Thanks,

James

Related branches

lp:~jml/launchpad/browse-source-code
Brad Crittenden (community): Approve (code) on 2009-10-06
Martin Albisetti (community): Approve (ui) on 2009-10-06
Diff: 97 lines
7 files modified
lib/lp/code/browser/branch.py (+1/-0)
lib/lp/code/browser/tests/test_product.py (+1/-2)
lib/lp/code/configure.zcml (+1/-0)
lib/lp/code/interfaces/branch.py (+3/-0)
lib/lp/code/model/branch.py (+4/-0)
lib/lp/code/model/tests/test_branch.py (+7/-0)
lib/lp/code/templates/product-branch-summary.pt (+1/-1)
Jonathan Lange (jml) wrote :

Oh yeah, I'll pay that.

Changed in launchpad-code:
importance: Undecided → Low
status: New → Triaged
tags: added: trivial ui
Jonathan Lange (jml) wrote :

I marked this bug as 'trivial', but didn't explain what needs to be done. Allow me to remedy this.

Edit lp/code/browser/branch.py, look for the codebrowse_url property and change it to link to the file browser view of the branch by passing 'files' as an argument to self.context.codebrowse_url().

To test this, run the code pagetests (./bin/test -cvvt stories/branches). This will take some time, but will be quite rewarding. If any of the tests fail, edit the .txt file to match the new behaviour.

If you have any problems with this, please contact me or ask on #launchpad-dev.

Jonathan Lange (jml) on 2009-10-09
Changed in launchpad-code:
status: Triaged → Fix Committed
assignee: nobody → Jonathan Lange (jml)
milestone: none → 3.1.10
Diogo Matsubara (matsubara) on 2009-11-10
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers