Collapsible fieldsets don't degrade gracefully when Javascript isn't available
Bug #367533 reported by
Graham Binns
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
With bug 367337 having broken all of Launchpad's Javascript it's now impossible to use the extra options section of the +filebug form because all of the input fields are currently hidden due to the way that <fieldset class="collapsible collapsed" /> elements get rendered and set-up.
We should re-write the code that handles collapsible sections so that it degrades gracefully when Javascript isn't available.
Related branches
lp:~sinzui/launchpad/progressive-enhancement-ftw
- j.c.sackett (community): Approve
- Richard Harding (community): Approve (code*)
-
Diff: 646 lines (+245/-134)17 files modifiedlib/lp/app/doc/lazr-js-widgets.txt (+13/-16)
lib/lp/app/javascript/autocomplete/autocomplete.js (+0/-7)
lib/lp/app/javascript/picker/tests/test_personpicker.html (+4/-4)
lib/lp/app/javascript/picker/tests/test_picker_patcher.html (+4/-4)
lib/lp/app/javascript/tests/test_multicheckboxwidget.html (+3/-4)
lib/lp/app/templates/inline-multicheckbox-widget.pt (+10/-9)
lib/lp/app/templates/inline-picker.pt (+15/-19)
lib/lp/bugs/javascript/bugtask_index.js (+1/-1)
lib/lp/bugs/javascript/official_bug_tags.js (+11/-8)
lib/lp/bugs/javascript/tests/test_official_bug_tags.html (+133/-0)
lib/lp/bugs/javascript/tests/test_official_bug_tags.js (+49/-0)
lib/lp/bugs/templates/bugtarget-macros-filebug.pt (+1/-3)
lib/lp/bugs/templates/official-bug-target-manage-tags.pt (+1/-3)
lib/lp/bugs/tests/testfiles/sourceforge-project-fronobulator.html (+0/-45)
lib/lp/bugs/tests/testfiles/sourceforge-tracker-5570.html (+0/-3)
lib/lp/registry/stories/project/xx-project-edit.txt (+0/-3)
lib/lp/registry/templates/product-index.pt (+0/-5)
| Changed in launchpad: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
Revision history for this message
| Martin Albisetti (beuno) wrote | #1 |
Revision history for this message
| Graham Binns (gmb) wrote Re: [Bug 367533] Re: Collapsible fieldsets don't degrade gracefully when Javascript isn't available | #2 |
Revision history for this message
| Diogo Matsubara (matsubara) wrote | #3 |
| affects: | launchpad → launchpad-foundations |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #4 |
| affects: | launchpad-foundations → launchpad-web |
| tags: | added: css javascript |
| tags: | added: ui-easy |
| tags: |
added: easy ui removed: ui-easy |
| Changed in launchpad: | |
| importance: | Medium → Low |
| Changed in launchpad: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| status: | Triaged → In Progress |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-ok |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: | added: disclosure sharing |
| Changed in launchpad: | |
| assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
Agreed, but just because it's easy to do. It's not really a Launchpad core feature.