builddmaster needs to be reworked to remove "accepted" queue
Bug #361192 reported by
Adam Conrad
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Jelmer Vernooij | ||
Bug Description
For some time now, the builddmaster machine has been running low on disk, and in discussions about what to do with it, we realised that the builddmaster workflow doesn't actually require the "accepted" queue.
Currently, when a build is completed, after it's uploaded to the librarian and inserted into the soyuz database, the upload directory is moved from incoming to accepted. Given that this doesn't occur until AFTER the librarian/soyuz updates are made, as long as we're checking that those updates happened sanely and cleanly, the mv could be changed to an rm, thus eliminating "accepted" altogether.
Related branches
lp:~jelmer/launchpad/bug361192-trivial
- Henning Eggers (community): Approve (code)
- Edwin Grubbs: Pending requested
-
Diff: 179 lines (+109/-10)3 files modifiedlib/lp/archiveuploader/tests/test_uploadprocessor.py (+77/-6)
lib/lp/archiveuploader/uploadprocessor.py (+29/-1)
lib/lp/soyuz/doc/soyuz-upload.txt (+3/-3)
lp:~jelmer/launchpad/bug361192
- Jelmer Vernooij (community): Disapprove (code)
-
Diff: 1146 lines (+257/-270)13 files modifiedlib/lp/archiveuploader/tests/__init__.py (+9/-3)
lib/lp/archiveuploader/tests/test_buildduploads.py (+2/-3)
lib/lp/archiveuploader/tests/test_ppauploadprocessor.py (+2/-5)
lib/lp/archiveuploader/tests/test_recipeuploads.py (+2/-3)
lib/lp/archiveuploader/tests/test_securityuploads.py (+3/-7)
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+58/-38)
lib/lp/archiveuploader/uploadprocessor.py (+63/-24)
lib/lp/buildmaster/interfaces/buildbase.py (+6/-5)
lib/lp/buildmaster/model/buildbase.py (+69/-103)
lib/lp/buildmaster/tests/test_buildbase.py (+28/-54)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+5/-20)
lib/lp/soyuz/doc/soyuz-upload.txt (+2/-3)
lib/lp/soyuz/scripts/soyuz_process_upload.py (+8/-2)
Revision history for this message
| Celso Providelo (cprov) wrote | #1 |
| Changed in soyuz: | |
| assignee: | nobody → Celso Providelo (cprov) |
| milestone: | none → pending |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Adam Conrad (adconrad) wrote | #2 |
| Changed in soyuz: | |
| assignee: | Celso Providelo (cprov) → nobody |
| tags: | added: buildd-manager |
| Changed in soyuz: | |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| Changed in soyuz: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #3 |
| Changed in soyuz: | |
| milestone: | pending → 10.06 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Medium since the accepted queue on disk can be cleaned via cronjob