IRevision and Revision do not match required and notNull.

Bug #358296 reported by Henning Eggers on 2009-04-09
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself

Bug Description

Looking at IRevision and its implementation Revsion I found that more fields are marked as "notNull=True" in the implementation than are marked as "required=True" in the interface. I would have thought that these should match.

IRevision required=True:
date_created, revision_date, karma_allocated

Revision notNull=True:
date_created, log_body, revision_author, revision_id, revision_date, karma_allocated

I stumbled onto this when I wanted to access revision_author.person and wondered if I'd needed to check revision_author for None first.

description: updated
Jonathan Lange (jml) on 2009-04-16
Changed in launchpad-bazaar:
importance: Undecided → Medium
status: New → Triaged
tags: added: cleanup
Tim Penhey (thumper) wrote :

Trivial fix for someone.

Changed in launchpad-code:
milestone: none → 2.2.7
Tim Penhey (thumper) on 2009-07-17
Changed in launchpad-code:
milestone: 2.2.7 → 2.2.9
Matthew Revell (matthew.revell) wrote :

Retargeting to 3.0, which is the new name for 2.2.9. Haven't renamed the milestone as the 3.0 milestone is in a different series.

Changed in launchpad-code:
milestone: 2.2.9 → 3.0
Tim Penhey (thumper) on 2009-09-18
Changed in launchpad-code:
milestone: 3.0 → 3.1.10
Tim Penhey (thumper) on 2009-10-02
Changed in launchpad-code:
milestone: 3.1.10 → none
Changed in launchpad:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers