IRevision and Revision do not match required and notNull.

Bug #358296 reported by Henning Eggers
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Looking at IRevision and its implementation Revsion I found that more fields are marked as "notNull=True" in the implementation than are marked as "required=True" in the interface. I would have thought that these should match.

IRevision required=True:
date_created, revision_date, karma_allocated

Revision notNull=True:
date_created, log_body, revision_author, revision_id, revision_date, karma_allocated

I stumbled onto this when I wanted to access revision_author.person and wondered if I'd needed to check revision_author for None first.

description: updated
Jonathan Lange (jml)
Changed in launchpad-bazaar:
importance: Undecided → Medium
status: New → Triaged
tags: added: cleanup
Revision history for this message
Tim Penhey (thumper) wrote :

Trivial fix for someone.

Changed in launchpad-code:
milestone: none → 2.2.7
Tim Penhey (thumper)
Changed in launchpad-code:
milestone: 2.2.7 → 2.2.9
Revision history for this message
Matthew Revell (matthew.revell) wrote :

Retargeting to 3.0, which is the new name for 2.2.9. Haven't renamed the milestone as the 3.0 milestone is in a different series.

Changed in launchpad-code:
milestone: 2.2.9 → 3.0
Tim Penhey (thumper)
Changed in launchpad-code:
milestone: 3.0 → 3.1.10
Tim Penhey (thumper)
Changed in launchpad-code:
milestone: 3.1.10 → none
Changed in launchpad:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.