Blank error message upon email failure

[Chow Loong Jin]

  affects launchpad
As can be seen below, the error message returned is blank. I was told in
#launchpad by joey that the error was:

Error message=Invalid signature for Chow Loong Jin %<email address hidden>
%3E:%0A Signature couldn%27t be verified: (7, 9, %27No public key%27)

-------- Forwarded Message --------
From: <email address hidden>
Reply-to: <email address hidden>
To: Chow Loong Jin <email address hidden>
Subject: Submit Request Failure
Date: Sat, 04 Apr 2009 22:56:10 -0000

An error occurred while processing a mail you sent to Launchpad's email
interface.

Error message:

Sorry, something went wrong when Launchpad tried processing your mail.
We've recorded what happened, and we'll fix it as soon as possible.
Apologies for the inconvenience.

If this is blocking your work, please file a question at
https://answers.edge.launchpad.net/launchpad/+addquestion
and include the error ID OOPS-1190CEMAIL7 in the description.

--
For more information about using Launchpad by e-mail, see
https://help.launchpad.net/EmailInterface
or send an email to <email address hidden>

--
Chow Loong Jin

[Björn Tillenius (bjornt)]

On Sat, Apr 04, 2009 at 11:27:30PM -0000, hyperair wrote:
> Public bug reported:
>
> affects launchpad
> As can be seen below, the error message returned is blank. I was told in
> #launchpad by joey that the error was:

It's not blank. The error message is the part below it. For unexpected
errors like these, we should remove the 'Error message:' part, since it
doesn't fit there.

> Error message=Invalid signature for Chow Loong Jin %<email address hidden>
> %3E:%0A Signature couldn%27t be verified: (7, 9, %27No public key%27)

This is an unexpected failure, and shouldn't be presented to users. The
'Error message' is only for expected errors, which we know doesn't
contain any sensitive information.

Although, that said, we should catch this error, and present a better
error message to the user. (I think we have a bug filed for this
already)