merge proposal mail context is confusing
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Unassigned |
Bug Description
The context (ie what merge proposal, state, etc) is too subtle in merge proposal mails compared to mail from answers or bugs. In this example:
---------------
To: Martin Pool <email address hidden>
From: Robert Collins <email address hidden>
Subject: merging this..
Date: Thu, 26 Mar 2009 00:18:28 -0000
However, next time you put a branch up for merge, please run the test
suite first. You would have seen your code was broken :)
Tests would be better, but I want to clear the decks so am just doing
it.
-Rob
-- =
https:/
You are subscribed to branch lp:pqm.
----------------
I have no clue from the subject line or body what he's talking about or who he's talking to with "merging this" until I read right down to the end. The To header is set as if it's a mail to me but Robert's not directly talking to me at all, I'm just getting copied on his mail to someone else. So it's quite confusing.
So I'd suggest:
1- Reconsidering setting the recipient into the To header
2- Putting [mp 3659] or something similar into the header
3- At the top of the mail, putting the merge proposal context, something like this
> regarding https:/
> proposed to merge into lp:pqm, state pending
Also it's not clear from this mail whether this is a comment or a vote (and if so what.)
tags: | added: code-review email |
Changed in launchpad-code: | |
status: | Incomplete → Fix Released |
Apparently they do sometimes have [Merge] in the subject but not always?