Allow anyone with upload rights to write to a package branch

Bug #347768 reported by Jonathan Lange on 2009-03-24
12
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Muharem Hrnjadovic

Bug Description

It would be nice if anyone allowed to upload to a package could also write to the official branches for that package.

Related branches

Jonathan Lange (jml) on 2009-03-24
Changed in launchpad-bazaar:
importance: Undecided → Medium
status: New → Triaged
Jonathan Lange (jml) wrote :

This is the most important outstanding package branches bug as far as the platform team are concerned.

Changed in launchpad-bazaar:
importance: Medium → High
Jonathan Lange (jml) wrote :

We have discussed the implementation of this feature in person over the last few months.

For official branches, the set of people who can write to them will be owner *AND* the set of people who can upload to the package (pocket?).

wgrant points out that it might be nice to have this behaviour for non-official branches.

On Fri, 2009-06-26 at 10:10 +0000, Jonathan Lange wrote:
> wgrant points out that it might be nice to have this behaviour for non-
> official branches.

Yes, I can see some attraction in that.

Was he suggesting this would be the case for every package branch, or
just a way to enable it for some?

Thanks,

James

William Grant (wgrant) wrote :

Allowing it for every branch would be pretty strange, so I'd like a per-branch option.

Colin Watson (cjwatson) wrote :

I don't object to there being a per-branch option, but if this is delaying the implementation for official branches in any way (is that the case?) then I'd like to suggest that it should be fixed for official branches first. This is only getting more urgent over time, as we effectively can't use James' imported branches for development right now ...

Robbie Williamson (robbiew) wrote :

Jonathan Lange wrote on 2009-04-24: "This is the most important outstanding package branches bug as far as the platform team are concerned." With that said, is there an approximate date set for when we can expect to have this fixed?

Tim Penhey (thumper) wrote :

Hopefully before jml is in Dublin :)

Changed in launchpad-code:
assignee: nobody → Jonathan Lange (jml)
milestone: none → 2.2.9
Jonathan Lange (jml) on 2009-07-22
Changed in launchpad-code:
status: Triaged → In Progress
Matthew Revell (matthew.revell) wrote :

Retargeting to 3.0, which is the new name for 2.2.9. Haven't renamed the milestone as the 3.0 milestone is in a different series.

Changed in launchpad-code:
milestone: 2.2.9 → 3.0

On Sat, Jul 25, 2009 at 1:26 AM, Matthew
Revell<email address hidden> wrote:
> Retargeting to 3.0, which is the new name for 2.2.9. Haven't renamed the
> milestone as the 3.0 milestone is in a different series.
>
> ** Changed in: launchpad-code
>    Milestone: 2.2.9 => 3.0
>

I have a work-in-progress patch for this, and would very much like it
to land as soon as possible, given this is the number one bug for the
distro wrt Code.

jml

Jonathan Lange (jml) wrote :

Here's the news.

I've landed a branch that extracts logic out of soyuz for permission checking. It was a time-consuming, unanticipated chunk of work. The function now lives in lp.archiveuploader.permission.

The linked branch has a set of unit tests for this change. One of the unit tests fails -- that's the one you need to make pass to fix this bug.

Muharem Hrnjadovic (al-maisan) wrote :

Hmm .. I took a stab at it. The test in question passes now (please see lp:~al-maisan/launchpad/dd-bug-no-1 for more detail). I hope this is what you had in mind and that the method added to make the test work (personMayEditBranch()) can be cleaned up and used in the forthcoming work.

Tim Penhey (thumper) on 2009-10-02
Changed in launchpad-code:
milestone: 3.0 → 3.1.10
Robbie Williamson (robbiew) wrote :

So are we close to having this fixed, since Muharem said the test works (Comment #11)?

Robbie Williamson wrote:
> So are we close to having this fixed, since Muharem said the test works
> (Comment #11)?
>

I overlooked a branch of jml's (his work in progress); my stuff works
but I need to have a look at lp:~jml/launchpad/upload-permission-joy and
probably merge/combine that with lp:~al-maisan/launchpad/dd-bug-no-1
(the latter being the solution I came up with).

Best regards

--
Muharem Hrnjadovic <email address hidden>
Public key id : B2BBFCFC
Key fingerprint : A5A3 CC67 2B87 D641 103F 5602 219F 6B60 B2BB FCFC

Jonathan Lange (jml) on 2009-10-20
Changed in launchpad-code:
assignee: Jonathan Lange (jml) → Muharem Hrnjadovic (al-maisan)
Muharem Hrnjadovic (al-maisan) wrote :

LP rev. 9732

Changed in launchpad-code:
status: In Progress → Fix Committed
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers