patches and attachments should be listed separately in bug reports

Bug #344054 reported by Savvas Radevic on 2009-03-17
8
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Abel Deuring

Bug Description

Patches and attachments in a bug report right side menu should be listed separately.

For example, as it is, the following bug report shows only "Bug attachments": https://bugs.launchpad.net/bugs/311732
Also, there is no patch listing in the plain text output of the bug report: https://bugs.launchpad.net/bugs/311732/+text

There should be two separate columns:
1. Bug attachments
2. Patches

This would make patches be more visible.
This should be applied to /+text as well!

Oleg Koptev (koptev-oleg) wrote :

Also I think useful feature might be adding of few attachment instantly instead of upload one attachment, then again choose 'Add a comment/attachment' and upload next.

William Grant (wgrant) on 2009-07-14
affects: launchpad → malone
Jonathan Lange (jml) on 2009-09-15
tags: added: patch-tracking
Deryck Hodge (deryck) on 2009-12-08
Changed in malone:
status: New → Triaged
importance: Undecided → High
tags: added: story-patch-report
Changed in malone:
assignee: nobody → Abel Deuring (adeuring)
Deryck Hodge (deryck) on 2009-12-08
Changed in malone:
status: Triaged → In Progress
Lucas Nussbaum (lucas) wrote :

Hi

I'm also very interested in having info on whether a specific attachment is a patch in the text output (/+text). It would also to export that information to Ultimate Debian Database, for example.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08.12.2009 23:50, Lucas Nussbaum wrote:
> Hi
>
> I'm also very interested in having info on whether a specific attachment
> is a patch in the text output (/+text). It would also to export that
> information to Ultimate Debian Database, for example.
>

Lucas, did you consider to use Launchpad's webservice API
(https://edge.launchpad.net/+apidoc/#bug_attachment ,
https://help.launchpad.net/API/)?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFLH2fqekBPhm8NrtARAhHzAJ4zW2nmdVgESbvWRqxrLA+LN9tSvwCfTM91
t1wk9Rx7ORh8H2jOWOPutNM=
=K8hA
-----END PGP SIGNATURE-----

Lucas Nussbaum (lucas) wrote :

Yes. The full context is that I'm importing all bugs affecting Ubuntu into Ultimate Debian Database on a daily basis, which takes a few hour. I discussed this with the LP team at UDS, and it is not clear that switching to using the API would provide any benefit (it might also require more HTTP requests than using the text interface).

So I don't plan to rewrite my code for now.

See https://bugs.launchpad.net/malone/+bug/231402 for a tentative discussion of what it would take to really improve the situation for me.

Changed in malone:
status: In Progress → Fix Committed
Lucas Nussbaum (lucas) wrote :

@Diogo: does that fix the +text format as well?

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09.12.2009 21:57, Lucas Nussbaum wrote:
> @Diogo: does that fix the +text format as well?
>

Unfortunately not :( (Diogo is periodically running a script that
searches bzr commit messages for strings like "[bug=1234]" and updates
the related bug's status)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFLILGaekBPhm8NrtARAvyrAJ4n73qtosizeFttZCO/k0zwv6EOpgCfaDg0
8rmWn1wAg2LKpeywK6vxaoQ=
=TDol
-----END PGP SIGNATURE-----

Deryck Hodge (deryck) on 2009-12-10
Changed in malone:
milestone: none → 3.1.12
Deryck Hodge (deryck) wrote :

Just to offer a bit more about what is fixed and not in the branch that was committed.....

We did not do the work to make this visible in +text. The API is the preferred way to get info out of Launchpad now. I realize this doesn't work for Lucas and possibly some others, but given the amount of pending work for the bugs team and our focus on using Launchpad's API, we won't be doing any work to update the +text interface. I know some will be disappointed, and I'm sorry about this.

We would, of course, accept branches from a contributor to update +text, but the full time bugs team is not going to work on this.

Abel Deuring (adeuring) wrote :

Technically, the change suggested by Lucas quite simple. I have a few spare cycles I could spend on this before going AWOL^W into holidays. But I am not sure about possible side-effects: If we split the patches into a separate list on the +text page, existing other scripts will break...

Abel Deuring (adeuring) wrote :

...erm, other scripts _could_ break...

Lucas Nussbaum (lucas) wrote :

bah, the text interface is not the recommended way to export data from LP anyway ;) and well written parsers would not break.

Another solution would be to fork the text interface into a "/+udd" interface or something. But the maintenance might be harder in the long run.

Deryck Hodge (deryck) wrote :

I'll leave it to Abel to decided if he can spare the cycles here. I suspect it will be more than is imaged, just based on how "it's an easy fix" comments usually end up. :)

And to be fair, there are lots of little bugs on malone right now that would also be easy fixes that bring wider benefit then applying this change to the +text interface. But if you're already in the code and it *really* is a small change, then by all means... :)

Deryck Hodge (deryck) on 2009-12-21
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers